Received-SPF: pass (google.com: domain of linux-nfs+bounces-3627-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <99655e83d1b2f3fa86ab95adbe3fd1746e8b4343.camel@kernel.org>
Subject: Re: [for-6.11 PATCH 06/29] sunrpc: add rpcauth_map_to_svc_cred
From: Jeff Layton <jlayton@kernel.org>
To: Mike Snitzer <snitzer@kernel.org>, linux-nfs@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>, Trond Myklebust
	 <trondmy@hammerspace.com>, snitzer@hammerspace.com
Date: Mon, 10 Jun 2024 08:19:41 -0400
In-Reply-To: <20240607142646.20924-7-snitzer@kernel.org>
References: <20240607142646.20924-1-snitzer@kernel.org>
	 <20240607142646.20924-7-snitzer@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-06-07 at 10:26 -0400, Mike Snitzer wrote:
> From: Weston Andros Adamson <dros@primarydata.com>
>=20
> Add new funtion rpcauth_map_to_svc_cred which maps a generic rpc_cred
> to an
> svc_cred suitable for use in nfsd.
>=20
> This is needed by the localio code to map nfs client creds to nfs
> server
> credentials.
>=20
> Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
> Signed-off-by: Lance Shelton <lance.shelton@hammerspace.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>
> ---
> =C2=A0include/linux/sunrpc/auth.h |=C2=A0 4 ++++
> =C2=A0net/sunrpc/auth.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 | 16 ++++++++++++++++
> =C2=A02 files changed, 20 insertions(+)
>=20
> diff --git a/include/linux/sunrpc/auth.h
> b/include/linux/sunrpc/auth.h
> index 61e58327b1aa..5ebf031361a1 100644
> --- a/include/linux/sunrpc/auth.h
> +++ b/include/linux/sunrpc/auth.h
> @@ -11,6 +11,7 @@
> =C2=A0#define _LINUX_SUNRPC_AUTH_H
> =C2=A0
> =C2=A0#include <linux/sunrpc/sched.h>
> +#include <linux/sunrpc/svcauth.h>
> =C2=A0#include <linux/sunrpc/msg_prot.h>
> =C2=A0#include <linux/sunrpc/xdr.h>
> =C2=A0
> @@ -184,6 +185,9 @@ int			rpcauth_uptodatecred(struct
> rpc_task *);
> =C2=A0int			rpcauth_init_credcache(struct rpc_auth *);
> =C2=A0void			rpcauth_destroy_credcache(struct rpc_auth
> *);
> =C2=A0void			rpcauth_clear_credcache(struct
> rpc_cred_cache *);
> +bool			rpcauth_map_to_svc_cred(struct rpc_auth *,
> +						const struct cred *,
> +						struct svc_cred *);
> =C2=A0char *			rpcauth_stringify_acceptor(struct rpc_cred
> *);
> =C2=A0
> =C2=A0static inline
> diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> index 04534ea537c8..55a03a3bcac2 100644
> --- a/net/sunrpc/auth.c
> +++ b/net/sunrpc/auth.c
> @@ -308,6 +308,22 @@ rpcauth_init_credcache(struct rpc_auth *auth)
> =C2=A0}
> =C2=A0EXPORT_SYMBOL_GPL(rpcauth_init_credcache);
> =C2=A0
> +bool
> +rpcauth_map_to_svc_cred(struct rpc_auth *auth, const struct cred
> *cred,
> +			struct svc_cred *svc)
> +{
> +	svc->cr_uid =3D cred->uid;
> +	svc->cr_gid =3D cred->gid;
> +	svc->cr_flavor =3D auth->au_flavor;
> +	svc->cr_principal =3D NULL;
> +	svc->cr_gss_mech =3D NULL;

Setting the above to NULLs makes me a little nervous, but these values
are usually handled at the RPC layer during svc_authenticate. The
localio code hooks in below that, so this should hopefully not be a
problem.

=20
> +	if (cred->group_info)
> +		svc->cr_group_info =3D get_group_info(cred-
> >group_info);
> +
> +	return true;
> +}
> +EXPORT_SYMBOL_GPL(rpcauth_map_to_svc_cred);
> +
> =C2=A0char *
> =C2=A0rpcauth_stringify_acceptor(struct rpc_cred *cred)
> =C2=A0{

--=20
Jeff Layton <jlayton@kernel.org>