Received-SPF: pass (google.com: domain of linux-nfs+bounces-3680-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
From: "NeilBrown" <neilb@suse.de>
To: "Mike Snitzer" <snitzer@kernel.org>
Cc: linux-nfs@vger.kernel.org, "Jeff Layton" <jlayton@kernel.org>,
 "Chuck Lever" <chuck.lever@oracle.com>,
 "Trond Myklebust" <trondmy@hammerspace.com>, snitzer@hammerspace.com
Subject: Re: [RFC PATCH v2 04/15] sunrpc: add rpcauth_map_to_svc_cred_local
In-reply-to: <20240612030752.31754-5-snitzer@kernel.org>
References: <20240612030752.31754-1-snitzer@kernel.org>,
 <20240612030752.31754-5-snitzer@kernel.org>
Date: Wed, 12 Jun 2024 14:28:14 +1000
Message-id: <171816649431.14261.3448167153955136615@noble.neil.brown.name>

On Wed, 12 Jun 2024, Mike Snitzer wrote:
> From: Weston Andros Adamson <dros@primarydata.com>
>=20
> Add new funtion rpcauth_map_to_svc_cred_local which maps a generic
> rpc_cred to an svc_cred suitable for use in nfsd.

This comment is stale.  There is not such thing as an "rpc_cred".

NeilBrown

>=20
> This is needed by the localio code to map nfs client creds to nfs
> server credentials.
>=20
> Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
> Signed-off-by: Lance Shelton <lance.shelton@hammerspace.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>
> ---
>  include/linux/sunrpc/auth.h |  4 ++++
>  net/sunrpc/auth.c           | 17 +++++++++++++++++
>  2 files changed, 21 insertions(+)
>=20
> diff --git a/include/linux/sunrpc/auth.h b/include/linux/sunrpc/auth.h
> index 61e58327b1aa..f8b561cf78ab 100644
> --- a/include/linux/sunrpc/auth.h
> +++ b/include/linux/sunrpc/auth.h
> @@ -11,6 +11,7 @@
>  #define _LINUX_SUNRPC_AUTH_H
> =20
>  #include <linux/sunrpc/sched.h>
> +#include <linux/sunrpc/svcauth.h>
>  #include <linux/sunrpc/msg_prot.h>
>  #include <linux/sunrpc/xdr.h>
> =20
> @@ -184,6 +185,9 @@ int			rpcauth_uptodatecred(struct rpc_task *);
>  int			rpcauth_init_credcache(struct rpc_auth *);
>  void			rpcauth_destroy_credcache(struct rpc_auth *);
>  void			rpcauth_clear_credcache(struct rpc_cred_cache *);
> +bool			rpcauth_map_to_svc_cred_local(struct rpc_auth *,
> +						      const struct cred *,
> +						      struct svc_cred *);
>  char *			rpcauth_stringify_acceptor(struct rpc_cred *);
> =20
>  static inline
> diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> index 04534ea537c8..f75728922d57 100644
> --- a/net/sunrpc/auth.c
> +++ b/net/sunrpc/auth.c
> @@ -308,6 +308,23 @@ rpcauth_init_credcache(struct rpc_auth *auth)
>  }
>  EXPORT_SYMBOL_GPL(rpcauth_init_credcache);
> =20
> +bool
> +rpcauth_map_to_svc_cred_local(struct rpc_auth *auth, const struct cred *cr=
ed,
> +			      struct svc_cred *svc)
> +{
> +	svc->cr_uid =3D cred->uid;
> +	svc->cr_gid =3D cred->gid;
> +	svc->cr_flavor =3D auth->au_flavor;
> +	if (cred->group_info)
> +		svc->cr_group_info =3D get_group_info(cred->group_info);
> +	/* These aren't relevant for local (network is bypassed) */
> +	svc->cr_principal =3D NULL;
> +	svc->cr_gss_mech =3D NULL;
> +
> +	return true;
> +}
> +EXPORT_SYMBOL_GPL(rpcauth_map_to_svc_cred_local);
> +
>  char *
>  rpcauth_stringify_acceptor(struct rpc_cred *cred)
>  {
> --=20
> 2.44.0
>=20
>=20
>=20