Received-SPF: pass (google.com: domain of linux-nfs+bounces-3681-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
From: "NeilBrown" <neilb@suse.de>
To: "Mike Snitzer" <snitzer@kernel.org>
Cc: linux-nfs@vger.kernel.org, "Jeff Layton" <jlayton@kernel.org>,
 "Chuck Lever" <chuck.lever@oracle.com>,
 "Trond Myklebust" <trondmy@hammerspace.com>, snitzer@hammerspace.com
Subject: Re: [RFC PATCH v2 07/15] nfs/nfsd: add "localio" support
In-reply-to: <20240612030752.31754-8-snitzer@kernel.org>
References: <20240612030752.31754-1-snitzer@kernel.org>,
 <20240612030752.31754-8-snitzer@kernel.org>
Date: Wed, 12 Jun 2024 14:36:18 +1000
Message-id: <171816697836.14261.17806813255162604456@noble.neil.brown.name>

On Wed, 12 Jun 2024, Mike Snitzer wrote:
> From: Weston Andros Adamson <dros@primarydata.com>
>=20
> Add client support for bypassing NFS for localhost reads, writes, and
> commits. This is only useful when the client and the server are
> running on the same host.
>=20
> nfs_local_probe() is stubbed out, later commits will enable client and
> server handshake via a LOCALIO protocol extension.
>=20
> This has dynamic binding with the nfsd module. Localio will only work
> if nfsd is already loaded.
>=20
> The "localio_enabled" nfs kernel module parameter can be used to
> disable and enable the ability to use localio support.
>=20
> Also, tracepoints were added for nfs_local_open_fh, nfs_local_enable
> and nfs_local_disable.
>=20
> Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
> Signed-off-by: Peng Tao <tao.peng@primarydata.com>
> Signed-off-by: Lance Shelton <lance.shelton@hammerspace.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>
> ---
>  fs/nfs/Makefile           |   2 +
>  fs/nfs/client.c           |   7 +
>  fs/nfs/inode.c            |   5 +
>  fs/nfs/internal.h         |  55 +++
>  fs/nfs/localio.c          | 798 ++++++++++++++++++++++++++++++++++++++
>  fs/nfs/nfstrace.h         |  61 +++
>  fs/nfs/pagelist.c         |   3 +
>  fs/nfs/write.c            |   3 +
>  fs/nfsd/Makefile          |   2 +
>  fs/nfsd/filecache.c       |   2 +-
>  fs/nfsd/localio.c         | 184 +++++++++
>  fs/nfsd/trace.h           |   3 +-
>  fs/nfsd/vfs.h             |   8 +
>  include/linux/nfs.h       |   6 +
>  include/linux/nfs_fs.h    |   2 +
>  include/linux/nfs_fs_sb.h |   5 +
>  include/linux/nfs_xdr.h   |   1 +
>  17 files changed, 1145 insertions(+), 2 deletions(-)
>  create mode 100644 fs/nfs/localio.c
>  create mode 100644 fs/nfsd/localio.c
>=20
> diff --git a/fs/nfs/Makefile b/fs/nfs/Makefile
> index 5f6db37f461e..ad9923fb0f03 100644
> --- a/fs/nfs/Makefile
> +++ b/fs/nfs/Makefile
> @@ -13,6 +13,8 @@ nfs-y 			:=3D client.o dir.o file.o getroot.o inode.o sup=
er.o \
>  nfs-$(CONFIG_ROOT_NFS)	+=3D nfsroot.o
>  nfs-$(CONFIG_SYSCTL)	+=3D sysctl.o
>  nfs-$(CONFIG_NFS_FSCACHE) +=3D fscache.o
> +nfs-$(CONFIG_NFS_V3_LOCALIO) +=3D localio.o
> +nfs-$(CONFIG_NFS_V4_LOCALIO) +=3D localio.o

Should be just

   nfs-$(CONFIG_NFS_LOCALIO_SUPPORT) +=3D localio.o

> =20
>  obj-$(CONFIG_NFS_V2) +=3D nfsv2.o
>  nfsv2-y :=3D nfs2super.o proc.o nfs2xdr.o
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index de77848ae654..c123ad22ac79 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -178,6 +178,10 @@ struct nfs_client *nfs_alloc_client(const struct nfs_c=
lient_initdata *cl_init)
>  	clp->cl_max_connect =3D cl_init->max_connect ? cl_init->max_connect : 1;
>  	clp->cl_net =3D get_net(cl_init->net);
> =20
> +#if defined(CONFIG_NFS_V3_LOCALIO) || defined(CONFIG_NFS_V4_LOCALIO)

Maybe CONFIG_NFS_LOCALIO_SUPPORT here too?  And one more place below.

NeilBrown