Received: by 2002:ab2:6f44:0:b0:1fd:c486:4f03 with SMTP id l4csp7243lqq; Wed, 12 Jun 2024 14:33:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVLDT0grt3qX/sIFvyDnj3SUZZkqc0myF0hhOTXjDtPdWex4sgmhvLq+8jn++kSqiJrxri6wXLuEnyUauQ8uOcxlHO5axGLaWvBXyriFQ== X-Google-Smtp-Source: AGHT+IExK0OaofjsunZLINkcgWRt3PLkEPtXQIUd8ezf6gXpS34O6On+oHZ2ULU55+OTQ8Kog0Qy X-Received: by 2002:a05:6a00:2d06:b0:705:9c08:c913 with SMTP id d2e1a72fcca58-705bce21c1emr3374255b3a.16.1718227999091; Wed, 12 Jun 2024 14:33:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718227999; cv=pass; d=google.com; s=arc-20160816; b=ho5MCXh/nIQ8PqfoSIaDwS4jdlm24NDfBNHcfD1WQoaOl5ptgNIpJcy0GmW5dr9DRT arFPp6vZJ/lBbMPkvYHtSB3GBu6GviruBX5z1PxKzrN2t/s1+aJIT9rp6+QC7cMJN8DK FrZJt5j1s0Kbfk7OEcuIeTicz4nM2QiXmExfOGPWDDvcs537HEM2i3Ab0l5VVR/UYnaR +RJd2a+7jB6zag9r9hDIep6oD1IQgWijV7M6VBUsBf1Ly+FXnQfNnaXHCPJINBQfgk2s 66KOKKo8zynEEjj6qlA86CrZXSaE5ogpKOfmWjL0tgEtWMSKhDGlzvGwUb5AH8yFI8df 1Q+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=6wiFx7egO4Dcw3vIN5dHZrcxtB+mg3NlPIqqzxXgMQ8=; fh=WAEBd+AJ+nnkiJ3thrMCpDOQcgIgL37E/fTg3DCh5N4=; b=D9OQlY91BsDN66dhHa1FSD0gOrO7vMB0vzd3oB17LpMdGUEP9m8Tv46Dy8aLZjzGSJ sPkBM8QHdhcrXxqkVewdQxCH04z19gQ16q9/cndlEUZxMom7RxKfYVqVb9Fn9KYdmAEK yCnXAfRrSTmbBtqeoc6x7XQqVK/aAKAW+a9umnuOOQpbDf3u9LPRxr+CY2UPTCfELPZd RPq3Wico075CHv+iCJdp72QqZD8oBtu/ZYbAFFX3H4IlsTPZQ80tFWIDa8zClb79A74x 7kY0i6x2abSbsTbjCUZrwCqafHTKvkY8C74wxnr/ijheV1mhJ+lu5hQLfr+YEbnIMxEl Ipfg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J4gew7GX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-3701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-3701-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-705cc961caesi29451b3a.90.2024.06.12.14.33.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 14:33:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-3701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J4gew7GX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-3701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-3701-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id AC51228430A for ; Wed, 12 Jun 2024 21:33:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE7AC126F0D; Wed, 12 Jun 2024 21:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J4gew7GX" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AF5721360; Wed, 12 Jun 2024 21:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718227987; cv=none; b=qPOGh3cBQ5vGzCpkT5nkfedRvukKoVpJ9t8sCqNS69O5sXGF22H3Fa67hgS4WwN+qBoh2bEVRGrp8r0z3N+MJhy78ija599nALW5sO5WTuFPVDT42wDGew6NKvoXr+kKfrcGzx+dDsSzZt55U0nJni5wW+ND7rkBpYtF0RlYi/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718227987; c=relaxed/simple; bh=D7/e9lxK/rDnF5q2wBJbSwFKBep+OjF1zHYFBRsOwHY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RBcrGrXaA1dgG3BtMGN9vY/WlFnWbMDlomUU7/dsIYW6Ey8fEEi8UqYvptj9MMTSecWNpT128fkxR4z5q9FOgsfc5HlZp4C7/jAlS+dIaIHT9bqlOMG3XIuiZ2BsCyT1JkxPzKD5NlwuM2zQFW0g0VlKoPK+fCzihNbHYTOs6eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J4gew7GX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B31DEC116B1; Wed, 12 Jun 2024 21:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718227987; bh=D7/e9lxK/rDnF5q2wBJbSwFKBep+OjF1zHYFBRsOwHY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J4gew7GXSUxZyxXl6G49+4erFfWm/fvqP8jJMq7QuXBUHyR17gKVbI8IJ3y71epYo 81Eq4piaIn37sHAKw45pOJJnpiTeuc2KSFxdSD1+2LioYDUAwYQQ8KGiGECKgXZ1Bt BQIkYrv1Z3RNFkSAHVf81GTPLI5u7plWmLvmv2tSr8XWK2kuYVByujH0Xm2sSG3rLe dcH3Q/OlBdRCiuZINoD5hS74CGC35ok/tQmpHn36JG4CCNQB6ctPj6kIhn5MA8jO7+ XDUBrtlraXPQiItIjFfHu36XD/1shI91JiWJHwx90qz33buNQ2dew6BWeH46IO/yU8 gdQU9P2cQi32g== Date: Wed, 12 Jun 2024 14:33:05 -0700 From: Jakub Kicinski To: Julia Lawall Cc: linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org, bridge@lists.linux.dev, linux-trace-kernel@vger.kernel.org, Mathieu Desnoyers , kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "Naveen N. Rao" , Christophe Leroy , Nicholas Piggin , netdev@vger.kernel.org, wireguard@lists.zx2c4.com, linux-kernel@vger.kernel.org, ecryptfs@vger.kernel.org, Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org, linux-can@vger.kernel.org, Lai Jiangshan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, "Paul E . McKenney" , Vlastimil Babka Subject: Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback Message-ID: <20240612143305.451abf58@kernel.org> In-Reply-To: <20240609082726.32742-1-Julia.Lawall@inria.fr> References: <20240609082726.32742-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 9 Jun 2024 10:27:12 +0200 Julia Lawall wrote: > Since SLOB was removed, it is not necessary to use call_rcu > when the callback only performs kmem_cache_free. Use > kfree_rcu() directly. > > The changes were done using the following Coccinelle semantic patch. > This semantic patch is designed to ignore cases where the callback > function is used in another way. How does the discussion on: [PATCH] Revert "batman-adv: prefer kfree_rcu() over call_rcu() with free-only callbacks" https://lore.kernel.org/all/20240612133357.2596-1-linus.luessing@c0d3.blue/ reflect on this series? IIUC we should hold off..