Received-SPF: pass (google.com: domain of linux-nfs+bounces-3771-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 13 Jun 2024 12:01:03 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: Neil Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Lorenzo Bianconi <lorenzo@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 0/5] nfsd/sunrpc: allow starting/stopping pooled NFS
 server via netlink
Message-ID: <ZmsXv3pS1ui1egpI@tissot.1015granger.net>
References: <20240613-nfsd-next-v2-0-20bf690d65fb@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240613-nfsd-next-v2-0-20bf690d65fb@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?zWviInQ9NUWCoNFckFzfX59HykmGS1L/rFxEGk3pQVYLe4DfJH7A03mV4EDm?=
 =?us-ascii?Q?Oaub79cerWnmBsSyxDPi0buLnPpIsVAIHklwRLjgx5qjK2Nbj4QHtHQIP5hW?=
 =?us-ascii?Q?J7Y6KNq4tc5BF6IF+8JQ9HVNMChvEFPq/gX5cdqU7vjvZ26CTqlH9o1n5sIF?=
 =?us-ascii?Q?9zfEPwvGuT4tR394+B0ss9cz9wgLQURboClsw59uppt68RcTJe63hA6XI3eb?=
 =?us-ascii?Q?jO6qPjMQ7jHGLycZVE7ALwp8mQsqjpE/vox0bBLYZDkLKHC9H8xme7wgcydF?=
 =?us-ascii?Q?pLBH+MslV4nOiDonVCZDK7UGno5eNqT2S0hd4o0PUcBYUUdJt2PqJumsygTV?=
 =?us-ascii?Q?15eyJXW0Rm2aLnM0QdHy0TbI4FTtZcMjaXCLV/krZ1xcX5h/3X49We/5QaQO?=
 =?us-ascii?Q?CZrMAhyrw3kFeMgXEoIo2uxZmB5HKg7NjzH02Jx+Jf55XrHMGaqbCOcu2E95?=
 =?us-ascii?Q?Fd3ddWCWaAHJQLcVndNT//+8gy8zTpYod7gwvQjjaJo6sCd95s0XCTO/cZpb?=
 =?us-ascii?Q?bx5aXqylzRGnxnkkYws/6USzpf2GTjAg27pID5h4gD7L3ybA3NzO0dPU6Aql?=
 =?us-ascii?Q?29gr4d86PotqDcliMeFe2axKnnvHKMuEbql1/1xFPhm9XuE9oYCashtzKMXv?=
 =?us-ascii?Q?ZXdjFE0NLD7rK4yAzsZ8U1wvHDZNzwdH0spu9v1fh+Biy2IjTeHyVBCNVzU1?=
 =?us-ascii?Q?wWi54J4ks+jIchYhMa2Yl48+HJT+PcKqSQm2PeoU97yVCsY8ZQx0voG7+d+C?=
 =?us-ascii?Q?7pn7Bj7ykmFBdOpeo2acr2pp+OUTmrdpPflmGGTP1pWt3pAbKEgCnqJ1Fy6t?=
 =?us-ascii?Q?d0qxAD1W/cFJel5wX1s6iZzpw4cOq/gVMXqU3il4FdX2jy6ntThfxW6TZFK/?=
 =?us-ascii?Q?u1svKkfUwJ4TP2a3U4EQnxIMmkmS+jBCea7YjJKWG5UNLp1/k+GQMm3FsWFY?=
 =?us-ascii?Q?RgRk7BlKrdHSicZj67grs3p+IELOXt6yrqVMUXhoMcRDl20dWHKXyzvPgVe3?=
 =?us-ascii?Q?6jM8NrizD2Eb7lg4ashF9gVXJWc4FxXv/3auPEG/me1B90NcswDWgVgYGhS2?=
 =?us-ascii?Q?q8ZTRk7MXX9xgTJOj6lf4kDZbShkDqj4z5JZWibIezUCT4lPlLUMgWLJfaL/?=
 =?us-ascii?Q?UubjyZjPUIg9XKMAswBqUfLJVL21lIWuM4Vr8V3Eudv6L4qYdENqb6k/1sXJ?=
 =?us-ascii?Q?w8CoVP4UlQusYqSdN/4TDQlDuAf/2lWyeYjNmUXgSsIGvvWvzWslfKsfP6cF?=
 =?us-ascii?Q?yriwp6I24mvLZHjHd80wtd77qmyEpWlYEFGeGtG+K/YAonijPTndVxhEvyU6?=
 =?us-ascii?Q?+DDb8r9fLmpJ49vRRl3eVGvgxb/xBCZR6zIS+yQDT9E5oDitOmagNwmiA7Jq?=
 =?us-ascii?Q?bHHxSBx9yYV8M1Og8EfeQHEUPwdVrkEwOYJl1+RjD2tAJiFwB8080Cd9fYX9?=
 =?us-ascii?Q?aXpw2xvoRDXQqniN+RmQnHPLLRHnNdjXBQzsgjQiAbDg3G9KmKi5TpiO/Xtx?=
 =?us-ascii?Q?IXuOrS0pucV/jNJsw01xdxATAbM0ImG1ZNNE8auUT5xWxSRFe3jngRUISDCr?=
 =?us-ascii?Q?A/4Q9rW/O+/eqrkUknOSIbvVHscPvXBouIWi3JY6Oft2F9pRGa3Iho0/Up7U?=
 =?us-ascii?Q?ZQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	L+EjbmlAQfQkMEq+RjJxiuOms6XV/L/CL7os7dN29VOmPYzqs8zJGp2EXR9y9TGyoP1+8nkP2NF/7WcmY1k/VoFCGKUb9CCpwrJQkG3xW15nUgj0IeLQKQz04n+dDBnCzQbngcFcamDgee1gWUp8PNxam4aLFLvAWxPoDovt+MUTcf3Nzh4YODXqm7Sw1Q0oE56DwYCJctfYYyouNMAlQFCQapcZBLmvqx9LpaoEnLVqAM0jW3B1gbk2+LwthjrtZGRYKjAxANld5yRJczMwMKpIEXKr/ELQNVY00ewyNgwAlrxZC6cDW+z09J315slR/wO1wl19mASeYDQfjPgzzQRHYr3kt4ME7ATVTw7+yDbGVH7KDSWMdeNIkCq0LD3IzISvl+OQa+5lRUsn4FWs/c8cqTsgIhoFtAPuxSA+24mBRSZncUjvEntvAQyuS/+LUaRnoYN+XNqstFADSIxqh5vzmTLS+DnZwyZ4Ff7yguHNJAPgrO4A9iYkI7iGljwURqxy/hMA2eXPMyEv3wCmUizR8g1uPeW187Ig7miihPHdxxRayCOS9dE1/p4ysXH+CaGuJP2LVaumPmUrlbdek2owXJF2UIaU/TrM/5iLZwM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d78cb77-03a2-42e5-968a-08dc8bc208f0
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 16:01:07.1513
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4XNcfjPwY+W3g2oHMC3llSXMw69LQV2eassoKzX0y3E+ZFJ8v5zk3eGL7+rgBUeqKgTNZzG0knSSccKWIoUc8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7197
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-13_09,2024-06-13_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=782
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2406130114
X-Proofpoint-GUID: -jzs8eiU01Uip7AzF4Za6SArZdtXYeQq
X-Proofpoint-ORIG-GUID: -jzs8eiU01Uip7AzF4Za6SArZdtXYeQq

On Thu, Jun 13, 2024 at 08:16:37AM -0400, Jeff Layton wrote:
> This is a resend of the patchset I sent a little over a week ago, with
> a couple of new patches that allow setting the pool-mode via netlink.
> 
> This patchset first attempts to detangle the pooled/non-pooled service
> handling in the sunrpc layer, unifies the codepaths that start the
> pooled vs. non-pooled nfsd, and then wires up the new netlink threads
> interface to allow you to start a pooled server by specifying an
> array of thread counts.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Changes in v2:
> - add new pool-mode set/get netlink calls

Applying this series to nfsd-next for broader exposure. Review
comments and test results are still welcome.

There are a couple of nits to be addressed in 2/5 and 4/5, and
we already discussed adding a disclaimer about changes to the
behavior of the /proc interface. So, can you fix these up and send
me a refresh?


> ---
> Jeff Layton (5):
>       sunrpc: fix up the special handling of sv_nrpools == 1
>       nfsd: make nfsd_svc call nfsd_set_nrthreads
>       nfsd: allow passing in array of thread counts via netlink
>       sunrpc: refactor pool_mode setting code
>       nfsd: new netlink ops to get/set server pool_mode
> 
>  Documentation/netlink/specs/nfsd.yaml |  27 +++++++++
>  fs/nfsd/netlink.c                     |  17 ++++++
>  fs/nfsd/netlink.h                     |   2 +
>  fs/nfsd/nfsctl.c                      | 102 +++++++++++++++++++++++++++++-----
>  fs/nfsd/nfsd.h                        |   3 +-
>  fs/nfsd/nfssvc.c                      |  30 +++++-----
>  include/linux/sunrpc/svc.h            |   3 +
>  include/uapi/linux/nfsd_netlink.h     |  10 ++++
>  net/sunrpc/svc.c                      | 102 +++++++++++++++++++++-------------
>  9 files changed, 225 insertions(+), 71 deletions(-)
> ---
> base-commit: fec4124bac55ad92c47585fe537e646fe108b8fa
> change-id: 20240604-nfsd-next-b04c0d2d89a9
> 
> Best regards,
> -- 
> Jeff Layton <jlayton@kernel.org>
> 

-- 
Chuck Lever