Received-SPF: pass (google.com: domain of linux-nfs+bounces-3791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ddb9488389cbb0c9395c3b634d05ed82a59fa604.camel@kernel.org>
Subject: Re: [PATCH 1/3] nfs: Drop pointless check from
 nfs_commit_release_pages()
From: Jeff Layton <jlayton@kernel.org>
To: Jan Kara <jack@suse.cz>, Trond Myklebust
 <trond.myklebust@hammerspace.com>
Cc: linux-nfs@vger.kernel.org, Neil Brown <neilb@suse.de>
Date: Thu, 13 Jun 2024 15:55:01 -0400
In-Reply-To: <20240613082821.849-1-jack@suse.cz>
References: <20240612153022.25454-1-jack@suse.cz>
	 <20240613082821.849-1-jack@suse.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-06-13 at 10:28 +0200, Jan Kara wrote:
> nfss->writeback is updated only when we are ending page writeback and
> at
> that moment we also clear nfss->write_congested. So there's no point
> in
> rechecking congestion state in nfs_commit_release_pages(). Drop the
> pointless check.
>=20
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> =C2=A0fs/nfs/write.c | 4 ----
> =C2=A01 file changed, 4 deletions(-)
>=20
> diff --git a/fs/nfs/write.c b/fs/nfs/write.c
> index 5fc12a721ec3..c6255d7edd3c 100644
> --- a/fs/nfs/write.c
> +++ b/fs/nfs/write.c
> @@ -1837,7 +1837,6 @@ static void nfs_commit_release_pages(struct
> nfs_commit_data *data)
> =C2=A0	struct nfs_page	*req;
> =C2=A0	int status =3D data->task.tk_status;
> =C2=A0	struct nfs_commit_info cinfo;
> -	struct nfs_server *nfss;
> =C2=A0	struct folio *folio;
> =C2=A0
> =C2=A0	while (!list_empty(&data->pages)) {
> @@ -1880,9 +1879,6 @@ static void nfs_commit_release_pages(struct
> nfs_commit_data *data)
> =C2=A0		/* Latency breaker */
> =C2=A0		cond_resched();
> =C2=A0	}
> -	nfss =3D NFS_SERVER(data->inode);
> -	if (atomic_long_read(&nfss->writeback) <
> NFS_CONGESTION_OFF_THRESH)
> -		nfss->write_congested =3D 0;
> =C2=A0
> =C2=A0	nfs_init_cinfo(&cinfo, data->inode, data->dreq);
> =C2=A0	nfs_commit_end(cinfo.mds);

Reviewed-by: Jeff Layton <jlayton@kernel.org>