Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp704576lqs; Fri, 14 Jun 2024 03:19:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUeBrfsxXIGHtpjWsN6i8L1V299U0Qf1d8jj5z0JkNTgM0KtQCPXEC154rs5bjeAiUflm9f68ZluVYTIPAIUSw3gENhhyyQZguxMnq5ig== X-Google-Smtp-Source: AGHT+IF5LhnQynN1MZj9E7tUiI3ZbIMlWWAErre5As1sfKuDHUhlQ3I9OhMQZlZk8ESWAehsDH/m X-Received: by 2002:a05:6870:4725:b0:254:d4e3:bde5 with SMTP id 586e51a60fabf-25842af0998mr2279811fac.44.1718360389666; Fri, 14 Jun 2024 03:19:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718360389; cv=pass; d=google.com; s=arc-20160816; b=HiCQ/RX0+V7zynioWDsRXIrtsr3aXo5R35tU8cDyCMopFUNC/IMeO8nXo3aueUQZ44 02TkCIyHnHWKV4TOp2o8PDnxfcsAuxUBcPJ9VV71zFQ1TNCYau/hiBlBJjY3jwLcHL6W ZXVWD/AqcXqs8C/DZj1GDb5AZD6z5EP2NoBSw+unnqtXe/RFUDNTANmpj0kT9fa+HJns o9cJuR5YsZZE3oUYCyV64DEsIE+9qmg0Tz/ezZrPsR2C0muMduxSMnlA+5Pk0vkpT36v DEbpt9lR9bmqpoMt3bpr3fifR1/o/sSyIWPvK3jQJlWy3giiMO4XbF4pfGcpk5OYmG47 cJng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=Y+h9mnigpjpNwUAOXWawpV3AcyMYOp0Q9u/JSf0OWCw=; fh=LH9SGfd/VXRDpUc98ifTpkzQuXzjRqjh+xqAfuPVXxU=; b=XVug0qAI/Qgxqs9zATfARuUUM+uRLMn/I/kiybNcu20tSQLECOTvS0anzF/TYcGo27 G7PfjX+KAAD5qoLnMVJro83annYAWprt1m2bNyD9zjSFFq8f0v+3XL3SVKTCZfqxUFSj n7UZQqUZfEW9Zbl5pgS25rXa941tQiYNgkj2c0xCydhtuSuznvcbbx6BGdstGRL5nKrb BqbzaQNOYrXJFCKBIhtSuzcCsIG9uvBFa1m4Rp44Bj7TOOlGOl5CijoVxz7tHXqzxZQx w7fr9p87Oue9UW0/3gpyyPVGToT2WcjxuWLzzQ7/z33xW2aWfXLbqZI9OaEcSSt+e6m8 bJdg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ujJgfi3t; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-nfs+bounces-3821-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-3821-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-705e1c36e88si201151b3a.287.2024.06.14.03.19.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 03:19:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-3821-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ujJgfi3t; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-nfs+bounces-3821-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-3821-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5CE6728398D for ; Fri, 14 Jun 2024 10:07:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6740195F03; Fri, 14 Jun 2024 10:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ujJgfi3t" X-Original-To: linux-nfs@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A38B192B7D; Fri, 14 Jun 2024 10:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718359415; cv=none; b=NpbS8PkKMmghKLd/sQU/P7HG9KvKVJEj99Q0bOiArdus8bfVLTNB+viiBcGZKqmNvzkGLPPbtRtgm6Uzw7kSa0jpafYfhyz831fD4ji4z5zaspVfJPPBC1eJ1AgXYklHI3MWbtvU67z0X5Edb6F9WgH12x2U4ltdP9Fcn2QrCfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718359415; c=relaxed/simple; bh=79Sp5ssPZoPT9qKyEZxZNvuP0Lw4eVu9irWLP4+NS7s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=J1O+jNbk/aS3yL4Q+2/dJ49qb+tqy7zQ93ek5hM8dxaXoZ9FzJ60tOuPLhWzrD8caycPNYgPD77oUBz0182jhKnrUNPD1ZaMoHdvCqMNpGabhR6funiLEWBET6doJY6oMvoC530Y9/0JsXQI+jSO6Ks4deUO6gt0z3S91fWImu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ujJgfi3t; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=Y+h9mnigpjpNwUAOXWawpV3AcyMYOp0Q9u/JSf0OWCw=; b=ujJgfi3t+Id15NzIWQvK0d9stL L3jS8QFAFFYlnPPhRu4LgMoMcSBHEI/OmyktKGKVaUmZvDvtIsqm7sa7uejK9asGqze2BpHixp0Ww VeBrtv1kfL/GvMDWUgxDULH6QENz6YNyyADTTNJM5JIwdqF6hr6B7cFc7HA/azrCUgKh9oyd3jDq9 DEeFD8S9yxP6Wtl6GuzJjNhCV0Wz05p80rj52AAvV9R5f69nQ73QMYSlLiNJKnKYP/iQWmOXthvb9 hwBCyVAI+1p4DnLLoUnBgoRaYwLA7VlEqR1XE4px3OBBl2FjNDtPqffzZ9gg8HmKMV/UawfGPMvIm GXReHQIA==; Received: from 2a02-8389-2341-5b80-6543-87c9-27d1-cd7c.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:6543:87c9:27d1:cd7c] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI3mO-00000002KgB-0Qk1; Fri, 14 Jun 2024 10:03:32 +0000 From: Christoph Hellwig To: Trond Myklebust , Anna Schumaker Cc: Steve French , Andrew Morton , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org Subject: fix swap on NFS Date: Fri, 14 Jun 2024 12:03:24 +0200 Message-ID: <20240614100329.1203579-1-hch@lst.de> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Hi all, as of 6.10-rc swap can swap out larger than PAGE_SIZE chunks, which trips a VM_BUG_ON in NFS. This trivial patch seems to fix it to me, but I haven't really figured out what Fixes tag this should get. Also cifs has the same VM_BUG_ON and will also need a similar fix, but I'll leave it to people with a working test setup.