Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1233133lqs; Fri, 14 Jun 2024 23:27:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU2g5+6uBipnpC65VaDSf9voH6zQqaZITjlWz7jRH0x9rROSJm9ejUAzMF5hnoR7g6L5CYDOV4/jm2AbGC4Go5hENhhBnANh5V9AfFLag== X-Google-Smtp-Source: AGHT+IGizSN8I3Gwj188SLd33PG51ESZI8kplEvT/uH64thz+I8T1vvc8dCaSqcoTTbPIKdG+9F5 X-Received: by 2002:a05:6808:3024:b0:3d2:2a9c:8b70 with SMTP id 5614622812f47-3d24e8de806mr5042268b6e.15.1718432836267; Fri, 14 Jun 2024 23:27:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718432836; cv=pass; d=google.com; s=arc-20160816; b=ZZF6rklW9KO3ccjJKnbodaq3sUjmdCo3XgWn1R75thjuV2H6ih2AdC1XmzOjMPJei6 8e3CMFPwRBWQLV//MdzqKRDtkFmu5fO1XSM8Rd63q2+TjtGoOcQ16A5Oo/7LOfaeZVV6 6TZYXw4Kdfq4K211yhiXPlioVB4xl3zffQxO+gQodpaiz+6Lm8b6+8JMvIiugDIpAWG0 tttBUomOmzpIX0vgAGQ9LwWXH/EMtltfB5DwaNAqrfk41ql53+RU37qO5oTmy2qcNuLv yuQUwVKkS4EQiHdaxUq9Rb5LO60cTwXuUAN50KZLGFxw1o/LHoQwFCWPM8+E/Nn8Wk2d ouNg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3/odegyH1+5kNTCmy075Qadt+XffdXfCQND4KxemL+o=; fh=SdSXshsM6TncJpclqIbqV6pt3IEtfTNawqtyozfLLCs=; b=I7a/5xKzRVmQlLXF3Xz6hIqn5LAbyE7C4Ny52GthBdhuGt/Hm6do9/dBOIyUFplNtR 4KKJzvoJRliQaNvGCsVUKXkKIVxbFSGHK1sQhrCYBIXWn8nsksPfQ1bDRR7EOXz0jR8U /ugkQGtPPqYM04HVNNQEJlOW1kw2qrLVsS87wJ8dKVBuV/5HKtndFrj/V8yLiz8BABPc 9HRzBl59ln11zbOduiNd58J5jDGnXdrZxDvvT9NzW4U+2Xx6EgmdPoKRK3uLZCckMzYg mb2oXXXW8sqnjLbqOYM9o5W0kWPPLXgpRwmEJqwApMhxg2JtpEUTWsX4H4w/SvBnHSaJ p3mQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Iy2taN7Y; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-nfs+bounces-3852-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-nfs+bounces-3852-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d2e1a72fcca58-705ccb3d2d0si5128651b3a.173.2024.06.14.23.27.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 23:27:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-3852-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Iy2taN7Y; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-nfs+bounces-3852-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-nfs+bounces-3852-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E005DB20DE9 for ; Sat, 15 Jun 2024 06:27:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9EB0016426; Sat, 15 Jun 2024 06:27:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Iy2taN7Y" X-Original-To: linux-nfs@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14D071640B for ; Sat, 15 Jun 2024 06:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718432829; cv=none; b=d9ctFdHtiArhbGYJgPsIUlbe+BYqnqa83Oybjz4CxuCpMdBLigwb10D/cr1d87l8bBYK0XmYCXkJsG3lE049TSB2/uz/Vz+GzkmO3G0y1ota6AMCYm/4hWdU2EZCG83ynaDTAbicnKAUyHNCtV6fwexd6AswJGhgASwjNHgg9VY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718432829; c=relaxed/simple; bh=sbnChAcZvhv+D2pfpg52EfCA1loZId4S5ut4pfE7OO8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a7tg1rlOF2MtU2xd/LvWY4N1NlCjy0i3yo8+GlJxtX8Col9k8ok1xtTWEan4YJQc+q0cqYwv4Zse693nEI5/C81mKfWD1ZG+3m17XIj0ZTNjpZ3TrHs7TmKBdBwMHYW5O1Xk6Kh9aJxBOaUtcGt5CGzb3ZuI/lj8GX5tkPA/6eQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Iy2taN7Y; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3/odegyH1+5kNTCmy075Qadt+XffdXfCQND4KxemL+o=; b=Iy2taN7YbrQ3KD0EUoYULnsQ96 Wvn6GuJ3QCliJt+Qnv2T6KapHGKB7F/r5oYIPul0plqMXofYDBSUHS0Yps2I3W7825Bn+IE5MtSvp 2GVGdjYkwPdiVz5FXSjgLidfaKgKxDIp2AV+pPInOWeoQ5uOti0+7bfyPyu6TFsTMpqAQ++6f9eVO K20uVIsiR9UGabgV9oKRZbShKPW3QW5CBDRauIHGp1eZvOkxkoLdtrOuvXyVq7WzqnFnS36xkyjE5 R6f9SofWAd6+o9mOFey6k3fzXMzHVny0/JrHFlbeO7KRvToegNVx99XOPBUM+6eptHH636Zeiqa76 7+J4NX+A==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIMsV-00000004ne5-0ww6; Sat, 15 Jun 2024 06:27:07 +0000 Date: Fri, 14 Jun 2024 23:27:07 -0700 From: Christoph Hellwig To: Jeff Layton Cc: trondmy@gmail.com, linux-nfs@vger.kernel.org, chuck.lever@oracle.com Subject: Re: [PATCH 00/19] OPEN optimisations and Attribute delegations Message-ID: References: <20240613041136.506908-1-trond.myklebust@hammerspace.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Fri, Jun 14, 2024 at 08:34:32AM -0400, Jeff Layton wrote: > This all looks pretty reasonable except for the last two patches. > Probably, they should be squashed together since there is no caller of > ->return_delegation until the last one. There is also nothing > describing the changes there, and I think it could use some explanation > (though I think I get what you're doing). > > Finally, I suppose we need to look at implementing support delstid in > knfsd as well. I'll open a new feature request for that the linux-nfs > project on github. I don't think there ever was a formal rule, but having a feature like this that affects all of the core nfs code without beeing able to test it against knfsd seems a bit dangerous indeed.