Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp1728140lqs; Sun, 16 Jun 2024 01:54:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWhbKjLwF02mXNsaxwfz4SblPNUyKmUEAhfhjMb2Kb4b/F+4zq+UcUqFWzi6StrCIJFCpFRX01MNAsALNr9oj2Z2f7gc97C1mz1hx2Tbw== X-Google-Smtp-Source: AGHT+IEK8f2MOrdm/YkN/Jowl0qj7YY6yxgNxvdcAhzvSnukqBOCcMN8mhQ/vEIS1ZxeVIoJvgW/ X-Received: by 2002:a17:906:380c:b0:a6f:1daa:9031 with SMTP id a640c23a62f3a-a6f60d5f513mr592376866b.42.1718528098902; Sun, 16 Jun 2024 01:54:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718528098; cv=pass; d=google.com; s=arc-20160816; b=XzYs8n2NRAnrFXImU/Lx5ZcEqfvX546M1IKrNw4zyNHvK0YdIG2Ec1DptjQ3aNiKEY IEbCLHuJF9Hc7UBsJu5V+dTSk7oo8gGss2vCBLFeNCxrA07jexvZlclVKlcwKpxO1D2L kvxvs964GOccLa1Jaovy/9gqKKqcr9hKfIQgms92Cy5JS8pWCMvZzsLKys5VSmDLcBTd 3VCcmerMGPV6/UR/sDSi3ntFrVw8M0K5Pdofn4o0u6Pv8kWfp0pmyg4y6btEb39oZ84O irrSee16uM7AeHwc0jXpoQSj7B4F9F7wH08enblPnaEZvHrK9UOl1bC68sP6TtR5yoyp aaVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=Ro6JB8C37V9YdMrgRBVxij9ik5Zo84f+MsAiQBy6M/w=; fh=HAmECKoPS8MsyLhSKhhyck/nZxR+XORKnnTC8yV6hkY=; b=KZEVDA2pGYSXljyePjKT301H+n7k2A3SaUcaXM2ZCavkzdAAbUxjxu5RsPLzf2Ba41 BW7KwK2v5+7JNWQpfyCEQ2JW6hL2S80/YEoUNQhhbY3Uim93WmUoCz8tMM+6LyXQkJUA DYUOd4dInMGoyltRSKQjG6zd7uy0NOXWOcBrBv8ONRaeMxBV9e6ilR020R4k4f1bxARJ UcF6jxlMaT4x8ipCsJAZSc5SRojVyTnKui+J9/ymQUoUmpJtSL6ODxg84S0ydsvOBXlc SLGzmaM0cKLuhOBrmC3PFKbbR/66MUvkygSv6rYmTD9Xc612xlymKo/4lNxTDF1PakWF Zi9g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-nfs+bounces-3857-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-3857-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f56dd5c8bsi352212766b.378.2024.06.16.01.54.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jun 2024 01:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-3857-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-nfs+bounces-3857-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-3857-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 912831F21370 for ; Sun, 16 Jun 2024 08:54:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D2866178CCB; Sun, 16 Jun 2024 08:54:51 +0000 (UTC) X-Original-To: linux-nfs@vger.kernel.org Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56EE61FF0; Sun, 16 Jun 2024 08:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718528091; cv=none; b=A5ajgdJ1NZoDtVneQmJGyeDLs/+8j5S/iQUnW7f0blv3D0rJUbOpNxiJwQeCpMLJmCGj6CKUqetEahTD8WFjCIbnavwrbEeCfqIoI0Nu4A1/KcEQIqYOihCkZfVkQFXie62evQPa+eF4RPyQBXMvbkaZ4f8Fj/bHYRuDfuUtIrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718528091; c=relaxed/simple; bh=ftFB80sqxyJ1Z+pS9SPnxv/3vGK8AqMjgp+JDNiifEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DUQoSXkKfagMIq0DTLDXahWUPhmkCbPJkgoXvW5AKKErgxPP1mDdO+nTt8ZAJCidCig4Hpl7vactpNVGABsybdNq8xDNSWtKyojPKWJKe4Vjb2/quHP03Vrx5/tVQBFXP4EV33s6IS/8oN1HOz1/fHf723QUpZDFh4hcQmthfWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 42E6168AFE; Sun, 16 Jun 2024 10:54:37 +0200 (CEST) Date: Sun, 16 Jun 2024 10:54:36 +0200 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: Andrew Morton , Christoph Hellwig , Trond Myklebust , Anna Schumaker , Steve French , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, Barry Song , Ryan Roberts Subject: Re: [PATCH] nfs: fix nfs_swap_rw for large-folio swap Message-ID: <20240616085436.GA28058@lst.de> References: <20240614100329.1203579-1-hch@lst.de> <20240614100329.1203579-2-hch@lst.de> <20240614112148.cd1961e84b736060c54bdf26@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Sun, Jun 16, 2024 at 12:16:10PM +1200, Barry Song wrote: > As I understand it, this isn't happening because we don't support > mTHP swapping out to a swapfile, whether it's on NFS or any > other filesystem. It does happen. The reason why I sent this patch is becaue I observed the BUG_ON trigger on a trivial swap generation workload (usemem.c from xfstests).