2007-11-29 23:03:32

by Tom Tucker

[permalink] [raw]
Subject: [RFC,PATCH 7/8] rdma: makefile


Add the NFSD_RDMA module to the sunrpc makefile.

Signed-off-by: Tom Tucker <[email protected]>
---

net/sunrpc/Makefile | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
index 92e1dbe..6d03dbf 100644
--- a/net/sunrpc/Makefile
+++ b/net/sunrpc/Makefile
@@ -15,3 +15,7 @@ sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o sched.o \
svc_xprt.o
sunrpc-$(CONFIG_PROC_FS) += stats.o
sunrpc-$(CONFIG_SYSCTL) += sysctl.o
+
+obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
+svcrdma-y := svc_rdma.o svc_rdma_transport.o \
+ svc_rdma_marshal.o svc_rdma_sendto.o svc_rdma_recvfrom.o


2007-12-03 17:03:04

by Chuck Lever III

[permalink] [raw]
Subject: Re: [RFC,PATCH 7/8] rdma: makefile

On Nov 29, 2007, at 5:45 PM, Tom Tucker wrote:
> Add the NFSD_RDMA module to the sunrpc makefile.

General question about how the RPC level RDMA code is organized: The
client-side RDMA service provider lives in its own subdirectory of
net/sunrpc. Should the server side provider also live in that
directory? Should these two be glued together into a single module?

> Signed-off-by: Tom Tucker <[email protected]>
> ---
>
> net/sunrpc/Makefile | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> index 92e1dbe..6d03dbf 100644
> --- a/net/sunrpc/Makefile
> +++ b/net/sunrpc/Makefile
> @@ -15,3 +15,7 @@ sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o
> sched.o \
> svc_xprt.o
> sunrpc-$(CONFIG_PROC_FS) += stats.o
> sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> +
> +obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
> +svcrdma-y := svc_rdma.o svc_rdma_transport.o \
> + svc_rdma_marshal.o svc_rdma_sendto.o svc_rdma_recvfrom.o


--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

2007-12-03 17:20:38

by Tom Tucker

[permalink] [raw]
Subject: Re: [RFC,PATCH 7/8] rdma: makefile

I don't know that it adds much, but perhaps for consistency? In fact, if
we were to move it, would we move it to the same directory as the
client?

On Mon, 2007-12-03 at 12:00 -0500, Chuck Lever wrote:
> On Nov 29, 2007, at 5:45 PM, Tom Tucker wrote:
> > Add the NFSD_RDMA module to the sunrpc makefile.
>
> General question about how the RPC level RDMA code is organized: The
> client-side RDMA service provider lives in its own subdirectory of
> net/sunrpc. Should the server side provider also live in that
> directory? Should these two be glued together into a single module?
>
> > Signed-off-by: Tom Tucker <[email protected]>
> > ---
> >
> > net/sunrpc/Makefile | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> > index 92e1dbe..6d03dbf 100644
> > --- a/net/sunrpc/Makefile
> > +++ b/net/sunrpc/Makefile
> > @@ -15,3 +15,7 @@ sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o
> > sched.o \
> > svc_xprt.o
> > sunrpc-$(CONFIG_PROC_FS) += stats.o
> > sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> > +
> > +obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
> > +svcrdma-y := svc_rdma.o svc_rdma_transport.o \
> > + svc_rdma_marshal.o svc_rdma_sendto.o svc_rdma_recvfrom.o
>
>
> --
> Chuck Lever
> chuck[dot]lever[at]oracle[dot]com


2007-12-03 17:21:57

by Tom Tucker

[permalink] [raw]
Subject: Re: [RFC,PATCH 7/8] rdma: makefile


On Mon, 2007-12-03 at 12:00 -0500, Chuck Lever wrote:
> On Nov 29, 2007, at 5:45 PM, Tom Tucker wrote:
> > Add the NFSD_RDMA module to the sunrpc makefile.
>
> General question about how the RPC level RDMA code is organized: The
> client-side RDMA service provider lives in its own subdirectory of
> net/sunrpc. Should the server side provider also live in that
> directory? Should these two be glued together into a single module?
>

I don't think so because the client and server are truly independent and
of course, you will often mount over RDMA, but not serve over RDMA.
What's the fan-out 20-1?

> > Signed-off-by: Tom Tucker <[email protected]>
> > ---
> >
> > net/sunrpc/Makefile | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> > index 92e1dbe..6d03dbf 100644
> > --- a/net/sunrpc/Makefile
> > +++ b/net/sunrpc/Makefile
> > @@ -15,3 +15,7 @@ sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o
> > sched.o \
> > svc_xprt.o
> > sunrpc-$(CONFIG_PROC_FS) += stats.o
> > sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> > +
> > +obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
> > +svcrdma-y := svc_rdma.o svc_rdma_transport.o \
> > + svc_rdma_marshal.o svc_rdma_sendto.o svc_rdma_recvfrom.o
>
>
> --
> Chuck Lever
> chuck[dot]lever[at]oracle[dot]com
> -
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html


2007-12-03 17:25:20

by [email protected]

[permalink] [raw]
Subject: Re: [RFC,PATCH 7/8] rdma: makefile

On Mon, Dec 03, 2007 at 11:24:59AM -0600, Tom Tucker wrote:
> I don't know that it adds much, but perhaps for consistency?

It's arguably a little friendlier for someone just learning their way
around the code--the rdma files are probably clutter to them on a first
pass.

> In fact, if we were to move it, would we move it to the same directory
> as the client?

That's what the gss code does, so I guess there's precedent.

No real strong opinion from me, though.

--b.

>
> On Mon, 2007-12-03 at 12:00 -0500, Chuck Lever wrote:
> > On Nov 29, 2007, at 5:45 PM, Tom Tucker wrote:
> > > Add the NFSD_RDMA module to the sunrpc makefile.
> >
> > General question about how the RPC level RDMA code is organized: The
> > client-side RDMA service provider lives in its own subdirectory of
> > net/sunrpc. Should the server side provider also live in that
> > directory? Should these two be glued together into a single module?
> >
> > > Signed-off-by: Tom Tucker <[email protected]>
> > > ---
> > >
> > > net/sunrpc/Makefile | 4 ++++
> > > 1 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> > > index 92e1dbe..6d03dbf 100644
> > > --- a/net/sunrpc/Makefile
> > > +++ b/net/sunrpc/Makefile
> > > @@ -15,3 +15,7 @@ sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o
> > > sched.o \
> > > svc_xprt.o
> > > sunrpc-$(CONFIG_PROC_FS) += stats.o
> > > sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> > > +
> > > +obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
> > > +svcrdma-y := svc_rdma.o svc_rdma_transport.o \
> > > + svc_rdma_marshal.o svc_rdma_sendto.o svc_rdma_recvfrom.o
> >
> >
> > --
> > Chuck Lever
> > chuck[dot]lever[at]oracle[dot]com
>