2007-12-10 22:40:57

by NeilBrown

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: sm-notify does not remove its pid file.

On Monday December 10, [email protected] wrote:
> It turns out that the sm-notify command, used to notify clients that
> they need to reclaim their locks because the server just changed
> state, does not clean up its pid file. The pid file is used to ensure
> only one instance of the process is running. This results in sm-notify
> exiting before notifying any clients on the second reboot.
> I also changed the directory in which the pid file is created from
> /var/run into BASEDIR so the file can be removed after the after the
> user id is changed to a non-root uid.

I was under the impression that /var/run was always cleaned out on
reboot, so this shouldn't be a problem. Is my impression wrong?

And I think the point of the lock file was the sm-notify would only
run once per reboot. You really wont it once per
lockd-forgets-all-locks so a kill -9 on lockd should be combined with
removing the lock file.

But I think that removing the lock file when sm-notify completes is

Note the comment in sm-notify.c:

* Record pid in /var/run/sm-notify.pid
* This file should remain until a reboot, even if the
* program exits.
* If file already exists, fail.