2007-12-10 17:09:35

by Tom Tucker

[permalink] [raw]
Subject: Re: [NFS] [PATCH] xprtrdma: fix XDR tail buf marshalling for all ops

On Mon, 2007-12-10 at 11:29 -0500, Trond Myklebust wrote:
> On Mon, 2007-12-10 at 11:23 -0500, Trond Myklebust wrote:
> > Look at the damned thing. _Every_ chunk in it has an 'if (read)' else.
> > It that is 'similar logic' then I'm a duck.
> ..or to spell it out:

> while (1) {
> if (Trond)
> write_sarky_mail();
> else
> quack();
> }
> is not a sign of 'similar logic'. It just means that both Trond and
> ducks do the same thing over and over again.

Ok, fair enough. It's a mix. What is combined is the encapsulating loop,
calls to memory registration and call to convert_iovs. But you are
correct, inside and outside the loop where the chunks are actually
formatted, there are if statements to discriminate the chunk type.


> Trond
> -
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html