2008-02-12 22:34:42

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH 10/11] NFSD: Remove redundant "select" clauses in fs/Kconfig

On Mon, Feb 11, 2008 at 05:12:38PM -0500, Chuck Lever wrote:
> As far as I can tell, selecting the CRYPTO and CRYPTO_MD5 entries under
> CONFIG_NFSD is redundant, since CONFIG_NFSD_V4 already selects
> RPCSEC_GSS_KRB5, which selects these entries.
>
> Testing with "make menuconfig" shows that the entries under CRYPTO still
> properly reflect "Y" or "M" based on the setting of CONFIG_NFSD after this
> change is applied.
>
> Signed-off-by: Chuck Lever <[email protected]>

And applied this. The rest I left alone for now.

--b.

> ---
>
> fs/Kconfig | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index fcaf61e..267ff73 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -1658,8 +1658,6 @@ config NFSD
> select SUNRPC
> select EXPORTFS
> select NFS_ACL_SUPPORT if NFSD_V2_ACL
> - select CRYPTO_MD5 if NFSD_V4
> - select CRYPTO if NFSD_V4
> help
> Choose Y here if you want to allow other computers to access
> files residing on this system using Sun's Network File System
>