2008-02-14 20:58:56

by Chuck Lever III

[permalink] [raw]
Subject: [PATCH 5/8] NFSD: Use "depends on" for PROC_FS dependency

Recently, commit 440bcc59 added a reverse dependency to fs/Kconfig to
ensure that PROC_FS was enabled if NFSD_V4 was enabled.

There is a guideline in Documentation/kbuild/kconfig-language.txt that
states "In general use select only for non-visible symbols (no prompts
anywhere) and for symbols with no dependencies."

A quick grep around other Kconfig files reveals that no entry currently
uses "select PROC_FS" -- every one uses "depends on". Thus CONFIG_NFSD_V4
should use "depends on PROC_FS" as well.

Signed-off-by: Chuck Lever <[email protected]>
---

fs/Kconfig | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/fs/Kconfig b/fs/Kconfig
index 90a2caa..be25ff3 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -1658,7 +1658,6 @@ config NFSD
select SUNRPC
select EXPORTFS
select NFS_ACL_SUPPORT if NFSD_V2_ACL
- select PROC_FS if NFSD_V4
select PROC_FS if SUNRPC_GSS
help
Choose Y here if you want to allow other computers to access
@@ -1720,8 +1719,7 @@ config NFSD_V3_ACL

config NFSD_V4
bool "NFS server support for NFS version 4 (EXPERIMENTAL)"
- depends on NFSD && NFSD_V3 && EXPERIMENTAL
- select FS_POSIX_ACL
+ depends on NFSD && NFSD_V3 && PROC_FS && EXPERIMENTAL
select RPCSEC_GSS_KRB5
help
This option enables support in your system's NFS server for