2008-02-05 18:09:13

by Chuck Lever III

Subject: [PATCH 06/10] NFSD: Remove NFSv4 dependency on NFSv3

Because NFSD_V4 "depends on" NFSD_V3, it appears as a child of the NFSD_V3
menu entry, and is not visible if NFSD_V3 is unselected.

Replace the dependency on NFSD_V3 with a "select NFSD_V3".

Signed-off-by: Chuck Lever <[email protected]>
---

fs/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/Kconfig b/fs/Kconfig
index 9ad62a9..4c16789 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -1723,7 +1723,8 @@ config NFSD_V3_ACL

config NFSD_V4
bool "NFS server support for NFS version 4 (EXPERIMENTAL)"
- depends on NFSD && NFSD_V3 && EXPERIMENTAL
+ depends on NFSD && EXPERIMENTAL
+ select NFSD_V3
select RPCSEC_GSS_KRB5
help
This option enables support in your system's NFS server for

2008-02-05 20:24:54

by J. Bruce Fields

Subject: Re: [PATCH 06/10] NFSD: Remove NFSv4 dependency on NFSv3

On Tue, Feb 05, 2008 at 01:09:12PM -0500, Chuck Lever wrote:
> Because NFSD_V4 "depends on" NFSD_V3, it appears as a child of the NFSD_V3
> menu entry, and is not visible if NFSD_V3 is unselected.

Are you really convinced this is a problem?

--b.

>
> Replace the dependency on NFSD_V3 with a "select NFSD_V3".
>
> Signed-off-by: Chuck Lever <[email protected]>
> ---
>
> fs/Kconfig | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 9ad62a9..4c16789 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -1723,7 +1723,8 @@ config NFSD_V3_ACL
>
> config NFSD_V4
> bool "NFS server support for NFS version 4 (EXPERIMENTAL)"
> - depends on NFSD && NFSD_V3 && EXPERIMENTAL
> + depends on NFSD && EXPERIMENTAL
> + select NFSD_V3
> select RPCSEC_GSS_KRB5
> help
> This option enables support in your system's NFS server for
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html