2008-03-27 20:34:55

by Chuck Lever III

[permalink] [raw]
Subject: [PATCH 2/3] SUNRPC: Remove PROC_FS dependency

Recently, commit 440bcc59 added a reverse dependency to fs/Kconfig to
ensure that PROC_FS was enabled if SUNRPC_GSS was enabled.

Apparently this isn't necessary because the auth_gss components under
net/sunrpc will build correctly even if PROC_FS is disabled, though
RPCSEC_GSS will not work without /proc.

It also violates the guideline in Documentation/kbuild/kconfig-language.txt
that states "In general use select only for non-visible symbols (no prompts
anywhere) and for symbols with no dependencies."

To address these issues, remove the dependency.

Signed-off-by: Chuck Lever <[email protected]>
---

fs/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/Kconfig b/fs/Kconfig
index db67512..373ee37 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -1668,7 +1668,6 @@ config NFSD
select SUNRPC
select EXPORTFS
select NFS_ACL_SUPPORT if NFSD_V2_ACL
- select PROC_FS if SUNRPC_GSS
help
Choose Y here if you want to allow other computers to access
files residing on this system using Sun's Network File System



2008-03-27 21:20:40

by [email protected]

[permalink] [raw]
Subject: Re: [PATCH 2/3] SUNRPC: Remove PROC_FS dependency

On Thu, Mar 27, 2008 at 04:34:47PM -0400, Chuck Lever wrote:
> Recently, commit 440bcc59 added a reverse dependency to fs/Kconfig to
> ensure that PROC_FS was enabled if SUNRPC_GSS was enabled.
>
> Apparently this isn't necessary because the auth_gss components under
> net/sunrpc will build correctly even if PROC_FS is disabled, though
> RPCSEC_GSS will not work without /proc.

It's only server-side RPCSEC_GSS that won't work without /proc.

And it still bugs me a little that you can select both RPCSEC_GSS and
NFSD and end up with something that doesn't actually support server-side
GSS.

But I don't know what to do about that; so, fine, applied.--b.

>
> It also violates the guideline in Documentation/kbuild/kconfig-language.txt
> that states "In general use select only for non-visible symbols (no prompts
> anywhere) and for symbols with no dependencies."
>
> To address these issues, remove the dependency.
>
> Signed-off-by: Chuck Lever <[email protected]>
> ---
>
> fs/Kconfig | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index db67512..373ee37 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -1668,7 +1668,6 @@ config NFSD
> select SUNRPC
> select EXPORTFS
> select NFS_ACL_SUPPORT if NFSD_V2_ACL
> - select PROC_FS if SUNRPC_GSS
> help
> Choose Y here if you want to allow other computers to access
> files residing on this system using Sun's Network File System
>