2008-04-14 17:01:04

by Chuck Lever III

[permalink] [raw]
Subject: [PATCH 10/24] SUNRPC: Use unsigned loop and array index in svc_init_buffer()

Clean up: Suppress a harmless compiler warning.

Index rq_pages[] with an unsigned type. Make "pages" unsigned as well,
as it never represents a value less than zero.

Signed-off-by: Chuck Lever <[email protected]>
---

net/sunrpc/svc.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index c1e763b..86a5b56 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -504,8 +504,7 @@ EXPORT_SYMBOL(svc_destroy);
static int
svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
{
- int pages;
- int arghi;
+ unsigned int pages, arghi;

pages = size / PAGE_SIZE + 1; /* extra page as we hold both request and reply.
* We assume one is at most one page
@@ -519,7 +518,7 @@ svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
rqstp->rq_pages[arghi++] = p;
pages--;
}
- return ! pages;
+ return pages == 0;
}

/*



2008-04-14 18:52:00

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH 10/24] SUNRPC: Use unsigned loop and array index in svc_init_buffer()

On Mon, Apr 14, 2008 at 12:27:52PM -0400, Chuck Lever wrote:
> Clean up: Suppress a harmless compiler warning.
>
> Index rq_pages[] with an unsigned type. Make "pages" unsigned as well,
> as it never represents a value less than zero.

OK.--b.

>
> Signed-off-by: Chuck Lever <[email protected]>
> ---
>
> net/sunrpc/svc.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index c1e763b..86a5b56 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -504,8 +504,7 @@ EXPORT_SYMBOL(svc_destroy);
> static int
> svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
> {
> - int pages;
> - int arghi;
> + unsigned int pages, arghi;
>
> pages = size / PAGE_SIZE + 1; /* extra page as we hold both request and reply.
> * We assume one is at most one page
> @@ -519,7 +518,7 @@ svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
> rqstp->rq_pages[arghi++] = p;
> pages--;
> }
> - return ! pages;
> + return pages == 0;
> }
>
> /*
>