2008-04-07 20:45:42

by Jeff Layton

Subject: [PATCH] SUNRPC: remove svc_create_thread()

Now that the nfs4 callback thread uses the kthread API, there are no
more users of svc_create_thread(). Remove it.

Signed-off-by: Jeff Layton <[email protected]>
---
include/linux/sunrpc/svc.h | 1 -
net/sunrpc/svc.c | 10 ----------
2 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index 64c9755..4b54c5f 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -386,7 +386,6 @@ struct svc_serv * svc_create(struct svc_program *, unsigned int,
void (*shutdown)(struct svc_serv*));
struct svc_rqst *svc_prepare_thread(struct svc_serv *serv,
struct svc_pool *pool);
-int svc_create_thread(svc_thread_fn, struct svc_serv *);
void svc_exit_thread(struct svc_rqst *);
struct svc_serv * svc_create_pooled(struct svc_program *, unsigned int,
void (*shutdown)(struct svc_serv*),
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 60c9e92..71023c7 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -613,16 +613,6 @@ out_thread:
}

/*
- * Create a thread in the default pool. Caller must hold BKL.
- */
-int
-svc_create_thread(svc_thread_fn func, struct svc_serv *serv)
-{
- return __svc_create_thread(func, serv, &serv->sv_pools[0]);
-}
-EXPORT_SYMBOL(svc_create_thread);
-
-/*
* Choose a pool in which to create a new thread, for svc_set_num_threads
*/
static inline struct svc_pool *
--
1.5.3.6

2008-04-07 20:53:39

by J. Bruce Fields

Subject: Re: [PATCH] SUNRPC: remove svc_create_thread()

On Mon, Apr 07, 2008 at 04:45:37PM -0400, Jeff Layton wrote:
> Now that the nfs4 callback thread uses the kthread API, there are no
> more users of svc_create_thread(). Remove it.

Thanks; applied.--b.

>
> Signed-off-by: Jeff Layton <[email protected]>
> ---
> include/linux/sunrpc/svc.h | 1 -
> net/sunrpc/svc.c | 10 ----------
> 2 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index 64c9755..4b54c5f 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -386,7 +386,6 @@ struct svc_serv * svc_create(struct svc_program *, unsigned int,
> void (*shutdown)(struct svc_serv*));
> struct svc_rqst *svc_prepare_thread(struct svc_serv *serv,
> struct svc_pool *pool);
> -int svc_create_thread(svc_thread_fn, struct svc_serv *);
> void svc_exit_thread(struct svc_rqst *);
> struct svc_serv * svc_create_pooled(struct svc_program *, unsigned int,
> void (*shutdown)(struct svc_serv*),
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 60c9e92..71023c7 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -613,16 +613,6 @@ out_thread:
> }
>
> /*
> - * Create a thread in the default pool. Caller must hold BKL.
> - */
> -int
> -svc_create_thread(svc_thread_fn func, struct svc_serv *serv)
> -{
> - return __svc_create_thread(func, serv, &serv->sv_pools[0]);
> -}
> -EXPORT_SYMBOL(svc_create_thread);
> -
> -/*
> * Choose a pool in which to create a new thread, for svc_set_num_threads
> */
> static inline struct svc_pool *
> --
> 1.5.3.6
>