2008-05-06 21:46:52

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH 0/17] svcrdma: RDMA transport driver close path cleanup

On Fri, May 02, 2008 at 11:28:24AM -0500, Tom Tucker wrote:
> Bruce:
> This patchset fixes a number of defects in the close path of the SVCRDMA
> transport provider. The defects were found by injecting errors on the
> transport at random intervals while running concurrent iozone tests on
> IB and iWARP mounts. With this set of patches applied I was able to run
> the the above tests for several hours without causing a crash or leaking
> resources. The transport recovers correctly on a client reconnect.
> This patchset is based on 2.6 top of tree, however, I think these fixes are
> good candidates for a 2.6.25 dot release as well.

It may be a lot to try to get in to 2.6.25.

Anyway, my (unfortunately superficial) review doesn't catch anything
serious. Up to you whether you'd like this version submitted or whether
you'd like to fix up those small things first.