2008-08-13 22:41:45

by Chuck Lever III

Subject: [PATCH 1/8] NFS: nfs_parsed_mount_options can use unsigned int

Eliminate mixed sign comparisons in nfs_compare_remount_options().

Signed-off-by: Chuck Lever <[email protected]>
---

fs/nfs/internal.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
index 24241fc..275a692 100644
--- a/fs/nfs/internal.h
+++ b/fs/nfs/internal.h
@@ -32,11 +32,11 @@ struct nfs_clone_mount {
*/
struct nfs_parsed_mount_data {
int flags;
- int rsize, wsize;
- int timeo, retrans;
- int acregmin, acregmax,
+ unsigned int rsize, wsize;
+ unsigned int timeo, retrans;
+ unsigned int acregmin, acregmax,
acdirmin, acdirmax;
- int namlen;
+ unsigned int namlen;
unsigned int bsize;
unsigned int auth_flavor_len;
rpc_authflavor_t auth_flavors[1];

2008-09-23 19:42:33

by Myklebust, Trond

Subject: Re: [PATCH 1/8] NFS: nfs_parsed_mount_options can use unsigned int

On Wed, 2008-08-13 at 18:39 -0400, Chuck Lever wrote:
> Eliminate mixed sign comparisons in nfs_compare_remount_options().
>
> Signed-off-by: Chuck Lever <[email protected]>

We really don't care about the sign, since we're always going to be
comparing for equality in nfs_compare_remount_options().

Cheers
Trond

> ---
>
> fs/nfs/internal.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
> index 24241fc..275a692 100644
> --- a/fs/nfs/internal.h
> +++ b/fs/nfs/internal.h
> @@ -32,11 +32,11 @@ struct nfs_clone_mount {
> */
> struct nfs_parsed_mount_data {
> int flags;
> - int rsize, wsize;
> - int timeo, retrans;
> - int acregmin, acregmax,
> + unsigned int rsize, wsize;
> + unsigned int timeo, retrans;
> + unsigned int acregmin, acregmax,
> acdirmin, acdirmax;
> - int namlen;
> + unsigned int namlen;
> unsigned int bsize;
> unsigned int auth_flavor_len;
> rpc_authflavor_t auth_flavors[1];
>
--
Trond Myklebust
Linux NFS client maintainer

NetApp
[email protected]
http://www.netapp.com