2013-09-12 13:09:43

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] sunrpc: Add missing kuids conversion for printing

m68k/allmodconfig:

net/sunrpc/auth_generic.c: In function ‘generic_key_timeout’:
net/sunrpc/auth_generic.c:241: warning: format ‘%d’ expects type ‘int’, but
argument 2 has type ‘kuid_t’

commit cdba321e291f0fbf5abda4d88340292b858e3d4d ("sunrpc: Convert kuids and
kgids to uids and gids for printing") forgot to convert one instance.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
net/sunrpc/auth_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c
index f6d84be..ed04869 100644
--- a/net/sunrpc/auth_generic.c
+++ b/net/sunrpc/auth_generic.c
@@ -239,7 +239,7 @@ generic_key_timeout(struct rpc_auth *auth, struct rpc_cred *cred)
if (test_and_clear_bit(RPC_CRED_KEY_EXPIRE_SOON,
&acred->ac_flags))
dprintk("RPC: UID %d Credential key reset\n",
- tcred->cr_uid);
+ from_kuid(&init_user_ns, tcred->cr_uid));
/* set up fasttrack for the normal case */
set_bit(RPC_CRED_NOTIFY_TIMEOUT, &acred->ac_flags);
}
--
1.7.9.5



2013-09-12 14:22:38

by Myklebust, Trond

[permalink] [raw]
Subject: Re: [PATCH] sunrpc: Add missing kuids conversion for printing

T24gVGh1LCAyMDEzLTA5LTEyIGF0IDE1OjA5ICswMjAwLCBHZWVydCBVeXR0ZXJob2V2ZW4gd3Jv
dGU6DQo+IG02OGsvYWxsbW9kY29uZmlnOg0KPiANCj4gbmV0L3N1bnJwYy9hdXRoX2dlbmVyaWMu
YzogSW4gZnVuY3Rpb24g4oCYZ2VuZXJpY19rZXlfdGltZW91dOKAmToNCj4gbmV0L3N1bnJwYy9h
dXRoX2dlbmVyaWMuYzoyNDE6IHdhcm5pbmc6IGZvcm1hdCDigJglZOKAmSBleHBlY3RzIHR5cGUg
4oCYaW504oCZLCBidXQNCj4gYXJndW1lbnQgMiBoYXMgdHlwZSDigJhrdWlkX3TigJkNCj4gDQo+
IGNvbW1pdCBjZGJhMzIxZTI5MWYwZmJmNWFiZGE0ZDg4MzQwMjkyYjg1OGUzZDRkICgic3VucnBj
OiBDb252ZXJ0IGt1aWRzIGFuZA0KPiBrZ2lkcyB0byB1aWRzIGFuZCBnaWRzIGZvciBwcmludGlu
ZyIpIGZvcmdvdCB0byBjb252ZXJ0IG9uZSBpbnN0YW5jZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6
IEdlZXJ0IFV5dHRlcmhvZXZlbiA8Z2VlcnRAbGludXgtbTY4ay5vcmc+DQo+IC0tLQ0KDQpUaGFu
a3MhIEFwcGxpZWQuLi4NCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQg
bWFpbnRhaW5lcg0KDQpOZXRBcHANClRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0
YXBwLmNvbQ0K