From: kbuild test robot <[email protected]>
fs/nfs/sysfs.c:125:2-7: WARNING: NULL check before some freeing functions is not needed.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Fixes: bf11fbdb20b3 ("NFS: Add sysfs support for per-container identifier")
Signed-off-by: kbuild test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
---
tree: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
head: c433a7975cfc839906aaa891f68d86ca228f7e43
commit: bf11fbdb20b385157b046ea7781f04d0c62554a3 [30/57] NFS: Add sysfs support for per-container identifier
:::::: branch date: 22 hours ago
:::::: commit date: 22 hours ago
Please take the patch only if it's a positive warning. Thanks!
sysfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/fs/nfs/sysfs.c
+++ b/fs/nfs/sysfs.c
@@ -121,8 +121,7 @@ static void nfs_netns_client_release(str
struct nfs_netns_client,
kobject);
- if (c->identifier)
- kfree(c->identifier);
+ kfree(c->identifier);
kfree(c);
}