2021-02-19 22:24:12

by Olga Kornievskaia

Subject: [PATCH v3 2/3] [NFS] cleanup: remove unneeded null check in nfs_fill_super()

From: Olga Kornievskaia <[email protected]>

In nfs_fill_super() passed in nfs_fs_context can never be NULL.

Signed-off-by: Olga Kornievskaia <[email protected]>
---
fs/nfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 4034102010f0..59d846d7830f 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -1026,7 +1026,7 @@ static void nfs_fill_super(struct super_block *sb, struct nfs_fs_context *ctx)
sb->s_blocksize = 0;
sb->s_xattr = server->nfs_client->cl_nfs_mod->xattr;
sb->s_op = server->nfs_client->cl_nfs_mod->sops;
- if (ctx && ctx->bsize)
+ if (ctx->bsize)
sb->s_blocksize = nfs_block_size(ctx->bsize, &sb->s_blocksize_bits);

if (server->nfs_client->rpc_ops->version != 2) {
--
2.27.0

2021-03-22 19:02:21

by Paul Moore

Subject: Re: [PATCH v3 2/3] [NFS] cleanup: remove unneeded null check in nfs_fill_super()

On Fri, Feb 19, 2021 at 5:24 PM Olga Kornievskaia
<[email protected]> wrote:
>
> From: Olga Kornievskaia <[email protected]>
>
> In nfs_fill_super() passed in nfs_fs_context can never be NULL.
>
> Signed-off-by: Olga Kornievskaia <[email protected]>
> ---
> fs/nfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Merged into selinux/next, thanks.

--
paul moore
http://www.paul-moore.com