2022-04-29 02:05:58

by NeilBrown

[permalink] [raw]
Subject: Re: [PATCH 2/2] NFS: rename nfs_direct_IO and use as ->swap_rw

On Fri, 29 Apr 2022, Andrew Morton wrote:
> On Fri, 29 Apr 2022 10:43:34 +1000 NeilBrown <[email protected]> wrote:
> > The nfs_direct_IO() exists to support SWAP IO, but hasn't worked for a
> > while. We now need a ->swap_rw function which behaves slightly
> > differently, returning zero for success rather than a byte count.
> >
> > So modify nfs_direct_IO accordingly, rename it, and use it as the
> > ->swap_rw function.
> >
> This one I insertion sorted into the series after
> mm-introduce-swap_rw-and-use-it-for-reads-from-swp_fs_ops-swap-space.patch.
> I can later fold this patch into that one of you think that's a better
> presentation?

I'm happy for the patches to remain separate - though adjacent is good.
If they were to be merged we'd need to fix up the commit message.
At least delete:

Future patches will restore swap-over-NFS functionality.