2023-03-03 18:21:39

by Roberto Sassu

[permalink] [raw]
Subject: [PATCH 12/28] fs: Fix description of vfs_tmpfile()

From: Roberto Sassu <[email protected]>

Update the description of vfs_tmpfile() to match the current parameters of
that function.

Fixes: 9751b338656f ("vfs: move open right after ->tmpfile()")
Signed-off-by: Roberto Sassu <[email protected]>
---
fs/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index 57727a1ae38..b4c52c4890b 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3574,9 +3574,9 @@ static int do_open(struct nameidata *nd,
/**
* vfs_tmpfile - create tmpfile
* @idmap: idmap of the mount the inode was found from
- * @dentry: pointer to dentry of the base directory
+ * @parentpath: pointer to the path of the base directory
+ * @file: file descriptor of the new tmpfile
* @mode: mode of the new tmpfile
- * @open_flag: flags
*
* Create a temporary file.
*
--
2.25.1



2023-03-06 10:30:19

by Christian Brauner

[permalink] [raw]
Subject: Re: [PATCH 12/28] fs: Fix description of vfs_tmpfile()

On Fri, Mar 03, 2023 at 07:18:26PM +0100, Roberto Sassu wrote:
> From: Roberto Sassu <[email protected]>
>
> Update the description of vfs_tmpfile() to match the current parameters of
> that function.
>
> Fixes: 9751b338656f ("vfs: move open right after ->tmpfile()")
> Signed-off-by: Roberto Sassu <[email protected]>
> ---

Trivially correct. But this shouldn't need to be a part of this series
afaict. Please send a this separately to fsdevel so we can pick it up
right now,

Acked-by: Christian Brauner <[email protected]>

2023-03-06 10:33:06

by Roberto Sassu

[permalink] [raw]
Subject: Re: [PATCH 12/28] fs: Fix description of vfs_tmpfile()

On Mon, 2023-03-06 at 11:28 +0100, Christian Brauner wrote:
> On Fri, Mar 03, 2023 at 07:18:26PM +0100, Roberto Sassu wrote:
> > From: Roberto Sassu <[email protected]>
> >
> > Update the description of vfs_tmpfile() to match the current parameters of
> > that function.
> >
> > Fixes: 9751b338656f ("vfs: move open right after ->tmpfile()")
> > Signed-off-by: Roberto Sassu <[email protected]>
> > ---
>
> Trivially correct. But this shouldn't need to be a part of this series
> afaict. Please send a this separately to fsdevel so we can pick it up
> right now,
>
> Acked-by: Christian Brauner <[email protected]>

Ok, thanks. I do the same for the EVM one.

Roberto