2023-03-09 06:21:18

by Zhi Li

Subject: [PATCH] [nfs/nfs-utils] rpcdebug: avoid buffer underflow if read() returns 0

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2176740

Signed-off-by: Zhi Li <[email protected]>
---
tools/rpcdebug/rpcdebug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/rpcdebug/rpcdebug.c b/tools/rpcdebug/rpcdebug.c
index 68206cc5..ec05179e 100644
--- a/tools/rpcdebug/rpcdebug.c
+++ b/tools/rpcdebug/rpcdebug.c
@@ -257,7 +257,7 @@ get_flags(char *module)
perror(filename);
exit(1);
}
- if ((len = read(sysfd, buffer, sizeof(buffer))) < 0) {
+ if ((len = read(sysfd, buffer, sizeof(buffer))) <= 0) {
perror("read");
exit(1);
}
--
2.39.0

2023-04-05 16:44:14

by Steve Dickson

Subject: Re: [PATCH] [nfs/nfs-utils] rpcdebug: avoid buffer underflow if read() returns 0

On 3/9/23 1:20 AM, Zhi Li wrote:
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2176740
>
> Signed-off-by: Zhi Li <[email protected]>
Committed... (tag: nfs-utils-2-6-3-rc7)

steved.
> ---
> tools/rpcdebug/rpcdebug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/rpcdebug/rpcdebug.c b/tools/rpcdebug/rpcdebug.c
> index 68206cc5..ec05179e 100644
> --- a/tools/rpcdebug/rpcdebug.c
> +++ b/tools/rpcdebug/rpcdebug.c
> @@ -257,7 +257,7 @@ get_flags(char *module)
> perror(filename);
> exit(1);
> }
> - if ((len = read(sysfd, buffer, sizeof(buffer))) < 0) {
> + if ((len = read(sysfd, buffer, sizeof(buffer))) <= 0) {
> perror("read");
> exit(1);
> }