2006-05-30 17:03:25

by Frédéric DALLEAU

[permalink] [raw]
Subject: [Bluez-devel] First try

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


Attachments:
pcm_a2dp.c.diff (5.54 kB)
(No filename) (0.00 B)
(No filename) (164.00 B)
Download all attachments

2006-06-19 08:03:08

by Frédéric DALLEAU

[permalink] [raw]
Subject: Re: [Bluez-devel] First try


>I had a look at your a2dp patches to move globals into the
>per-connection struct. It all looks like a clear improvement. I didn't
>have any problems with changes in quality after the change.
>
>Would you like to check things out of cvs and verify it works for you?
> =

>
Sorry for the long silence, I'm working on something else. I'm pleased =

you integrated my previous patch, it works well.

I tried two headset at a time. It does'nt crash, but I have bad sound. I =

believe this is due to bandwith limit. My bluetooth dongle is USB so =

there is enough bandwith. And bluetooth is 700 kb/s so I thought it =

should be enough to pass sbc data. I believed sbc was 128 kb/s. Maybe it =

is per channel... Can you confirm?

Thank you!
Fr=E9d=E9ric.



_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-06-06 05:05:48

by Brad Midgley

[permalink] [raw]
Subject: Re: [Bluez-devel] First try

Fr=E9d=E9ric

I had a look at your a2dp patches to move globals into the
per-connection struct. It all looks like a clear improvement. I didn't
have any problems with changes in quality after the change.

Would you like to check things out of cvs and verify it works for you?

thanks
Brad


_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-06-01 08:27:30

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] First try

Hi Frederic,

> >could you resend as a 'diff -u' output?
>
> this is the command line I use is that correct?
>
> cvs diff -u pcm_a2dp.c > pcm_a2dp.c.diff-u

you should have a .cvsrc file in $HOME that looks like this:

cvs -z3
diff -u
update -dP
checkout -P

> Now the output has +- instead of ><

It is called unified diff and it is the preferred format around any open
source project. I don't know of anybody who ever has reviewed a context
diff.

Regards

Marcel




_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-06-01 07:19:56

by Brad Midgley

[permalink] [raw]
Subject: Re: [Bluez-devel] First try

Fr=E9d=E9ric

> I just tried to move global variables to pcm_a2dp struct... However, I
> seem to experience a loss in quality. I'm really unsure about it. I
> don't understand why as it is a straight forward fix. Could you please
> review it?
> It's based on the latest cvs.

could you resend as a 'diff -u' output?

thanks for your work on this...

brad


_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel