Return-Path: From: Guy Harris To: Marcel Holtmann Cc: Paul Ionescu , BlueZ Mailing List , ethereal-dev@ethereal.com Subject: Re: [Ethereal-dev] Re: [Bluez-devel] bluetooth ethereal dissector Message-ID: <20031030035431.A18203@quadrajet.sonic.net> References: <1067379074.2419.24.camel@paul> <1067425631.24043.224.camel@pegasus> <1067482224.18114.6.camel@pegasus> <1067513580.18114.20.camel@pegasus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1067513580.18114.20.camel@pegasus>; from marcel@holtmann.org on Thu, Oct 30, 2003 at 12:39:46PM +0100 Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Date: Thu, 30 Oct 2003 03:54:31 -0800 On Thu, Oct 30, 2003 at 12:39:46PM +0100, Marcel Holtmann wrote: > Attached is another patch against CVS, which re-introduces the byte > swapping, I've checked in a change to replace g_ntohs with GUINT16_FROM_LE and to replace g_ntohl with GUINT32_FROM_LE. > I also use the macro _U_ for __attribute((packed))__ The macro _U_ is defined as __attribute__((unused)), not __attribute((packed))__. If __attribute((packed))__ is *required* in order to make it work, then you need to find some *other* way to make it work - conditionally using __attribute((packed))__ or not depending on whether GCC is being used or not won't help. For example, define the structure as an array of bytes, or as a sequence of arrays of bytes, and use the "pletoh" macros to extract values from them. However, I see nothing that would *require* __attribute((packed))__. ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel