Return-Path: Message-ID: From: Claudio Takahasi To: bluez-devel@lists.sourceforge.net Subject: Re: [Bluez-devel] hcid D-Bus patch In-Reply-To: <1127292701.495.11.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_393_22977905.1127306974749" References: <1127292701.495.11.camel@localhost.localdomain> Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 21 Sep 2005 09:49:34 -0300 ------=_Part_393_22977905.1127306974749 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Marcel, I will analize our comments. service_table_t and the function create_error_reply_message will be shared by other profiles(pan, hid, rfcomm, ...) this the reason to put in the dbus-internal.h file. Regarding the Bluetooth error codes, we can add the code in the D-Bus error messages as a argument. My proposal is use a standard like this: org.bluez.hci.error.UnknowMethod org.bluez.hci.error.WrongSignature org.bluez.hci.error.WrongParam org.bluez.hci.error.Failed /* here we can add the bluetooth error code */ org.bluez.hci.error.Busy org.bluez.hci.error.NoDevFound I will send a new path soon. Regards, Claudio. On 9/21/05, Marcel Holtmann wrote: > > Hi Claudio, > > > I am sending the initial patch that implementing the skeleton > > of the hcid D-Bus services. > > > > Run hcid with a non-daemon option to see the output > > > > Send the following messages to see the message handling. > > > > dbus-send --system --type=3Dmethod_call --dest=3Dorg.bluez /org/bluez/h= ci > > org.bluez.hci.PeriodicInqReq byte:1 byte:2 byte:3 > > dbus-send --system --type=3Dmethod_call --dest=3Dorg.bluez /org/bluez/h= ci > > org.bluez.hci.CancelPeriodicInqReq > > dbus-send --system --type=3Dmethod_call --dest=3Dorg.bluez /org/bluez/h= ci > > org.bluez.hci.InquiryReq byte:1 > > dbus-send --system --type=3Dmethod_call --dest=3Dorg.bluez /org/bluez/h= ci > > org.bluez.hci.RoleSwitchReq string:panu byte:1 > > > > Suggestions are welcome! > > I am not complete through all the changes yet, because the last week was > quite busy. However for what do we need a dbus-internal.h? I don't see > any need for it and it would be great if everything is inside dbus.h. If > we reach the level where stuff gets more generic and can also be reused > by pand etc. then we should think about moving it into the common/ > toplevel directory. The same applies for common.c. For now simply put > into dbus.c and resend the patch. > > I am not happy with EXEC_RESULT. We should simply use an uint32 for it > and then reuse the Bluetooth error codes and define some special ones > for us. The enum is the wrong choice here. > > Regards > > Marcel > > > > > ------------------------------------------------------- > SF.Net email is sponsored by: > Tame your development challenges with Apache's Geronimo App Server. > Download it for free - -and be entered to win a 42" plasma tv or your ver= y > own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php > _______________________________________________ > Bluez-devel mailing list > Bluez-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bluez-devel > ------=_Part_393_22977905.1127306974749 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Marcel,

I will analize our comments.

service_table_t and the function create_error_reply_message will be shared = by other profiles(pan, hid, rfcomm, ...)
this the reason to put in the dbus-internal.h file.
Regarding the Bluetooth error codes, we can add the code in the D-Bus error= messages as a argument. My proposal
is use a standard like this:

or= g.bluez.hci.error.UnknowMethod
org.bluez.hci.error.WrongSignature
org.bluez.hci.error.WrongParam
org.bluez.hci.error.Failed  /* here we can add the bluetooth error cod= e */
org.bluez.hci.error.Busy
org.bluez.hci.error.NoDevFound

I w= ill send a new path soon.

Regards,
Claudio.

On 9/21/05, Marcel Holtmann <marcel@holtmann.org> wrote:
Hi Claudio,

> I am sending the initial patch that implementing th= e skeleton
> of the hcid D-Bus services.
>
> Run hcid wit= h a non-daemon option to see the output
>
> Send the following = messages to see the message handling.
>
> dbus-send --system --type=3Dmethod_call --dest=3Dorg.bluez= /org/bluez/hci
> org.bluez.hci.PeriodicInqReq byte:1 byte:2 byte:3> dbus-send --system --type=3Dmethod_call --dest=3Dorg.bluez /org/blue= z/hci
> org.bluez.hci.CancelPeriodicInqReq
> dbus-send --system --ty= pe=3Dmethod_call --dest=3Dorg.bluez /org/bluez/hci
> org.bluez.hci.In= quiryReq byte:1
> dbus-send --system --type=3Dmethod_call --dest=3Dor= g.bluez /org/bluez/hci
> org.bluez.hci.RoleSwitchReq string:panu byte:1
&= gt;
> Suggestions are welcome!

I am not complete through all t= he changes yet, because the last week was
quite busy. However for what d= o we need a=20 dbus-internal.h? I don't see
any need for it and it would be great if ev= erything is inside dbus.h. If
we reach the level where stuff gets more g= eneric and can also be reused
by pand etc. then we should think about mo= ving it into the common/
toplevel directory. The same applies for common.c. For now simply putinto dbus.c and resend the patch.

I am not happy with EXEC_RESULT.= We should simply use an uint32 for it
and then reuse the Bluetooth erro= r codes and define some special ones
for us. The enum is the wrong choice here.

Regards

Marcel=




-------------------------------------------------------=
SF.Net email is sponsored by:
Tame your development challenges with = Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or y= our very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/= lists/listinfo/bluez-devel

------=_Part_393_22977905.1127306974749-- ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel