Subject: Re: [Bluez-devel] [DBUS Patch] Device Property
From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
In-Reply-To: <3013cac80511221152t2911f513jb28f3944097c1b09@mail.gmail.com>
References: <3013cac80511040603k52c40da2gae5249abcba426d9@mail.gmail.com>
	 <20051108222033.GA12368@localhost.localdomain>
	 <1131489534.5544.20.camel@blade>
	 <3013cac80511171116n33c7faech6006e7264821fb16@mail.gmail.com>
	 <3013cac80511171252g4a4f1581l915e364a244ec8ea@mail.gmail.com>
	 <20051118082828.GA16438@localhost.localdomain>
	 <3013cac80511180251w1d2fa8f5s80ce1da7318327e7@mail.gmail.com>
	 <20051118112611.GA17062@localhost.localdomain>
	 <3013cac80511180500h5539d5d9y3f19ce224f9e38b7@mail.gmail.com>
	 <1132660308.28644.37.camel@blade>
	 <3013cac80511221152t2911f513jb28f3944097c1b09@mail.gmail.com>
Content-Type: text/plain
Message-Id: <1132805822.5982.15.camel@blade>
Mime-Version: 1.0
Sender: bluez-devel-admin@lists.sourceforge.net
Errors-To: bluez-devel-admin@lists.sourceforge.net
Reply-To: bluez-devel@lists.sourceforge.net
Date: Thu, 24 Nov 2005 05:17:02 +0100

Hi Eduardo,

> here is the new patch. I've removed the spaces (I hope so). I've also
> included the code for the dbus signal for the local name change event.
> One thing that remainded open was the timeout for hci_send_req for
> name write and name read ops. In the hciconfig this was 2s and 1s. Is
> there a reason for this big number?

you missed one whitespace/tab clash, but I fixed it. Opening a patch
inside an editor with whitespace visualization helps a lot.

The patch has been applied to the CVS and we should talk about some
serious security setting for the D-Bus interface. Question is what a
session user should be able to change?

The timeout is not really crucial for most local configuration settings
and I think it was a bad idea to have it in the API anyhow. However the
change local name command is tricky. Some older CSR chips for example
are storing the name in the PS keys, which results writing it to flash
or EEPROM. This simply can take time.

Regards

Marcel


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel