Return-Path: Message-ID: <3013cac80512070801o5b60cc20y7098dc36f2326458@mail.gmail.com> From: Eduardo Rocha To: bluez-devel@lists.sourceforge.net Subject: Re: [Bluez-devel] [DBUS Patch] Device Property In-Reply-To: <1133960579.3752.17.camel@blade> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1132872886.3170.3.camel@blade> <3013cac80511251034s23d549cbs8a951d64562627b1@mail.gmail.com> <1132944074.5577.28.camel@blade> <1132949177.10237.5.camel@blade> <3013cac80512010855v46eeb99dk3a53094238800621@mail.gmail.com> <1133471112.18554.8.camel@blade> <3013cac80512070429g5fb992b7i7131d570f9023086@mail.gmail.com> <20051207125556.GA13152@localhost.localdomain> <1133960579.3752.17.camel@blade> Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 7 Dec 2005 13:01:38 -0300 Hi Johan and Marcel, I'll do that. Maybe should be a good idea to think how to split dbus.c into 2 or 3 files. Also, we should improve the debug messages. BR, Eduardo. On 12/7/05, Marcel Holtmann wrote: > Hi Johan, > > > Your patch looks ok, except that you seem to append the arguments in > > the wrong order to the "name" property changed signal: > > > > On Wed, Dec 07, 2005, Eduardo Rocha wrote: > > > dbus_message_append_args(message, > > > DBUS_TYPE_STRING, &pname, > > > + DBUS_TYPE_STRING, &pprop_name, > > and some coding style issues :( > > > Btw, maybe we should have a common function for sending property change= d > > signals, e.g: > > send_property_changed(const char *prop_name, int prop_type, void *value= ); > > Sounds like a good idea to me. Please integrate this and if needed split > the patch into two separate patches. > > Regards > > Marcel > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log fi= les > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_id=3D7637&alloc_id=3D16865&op=3Dclick > _______________________________________________ > Bluez-devel mailing list > Bluez-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bluez-devel > -- Eduardo Rocha Instituto Nokia de Tecnologia - INdT ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel