Return-Path: Message-ID: From: Claudio Takahasi To: bluez-devel@lists.sourceforge.net Subject: Re: [Bluez-devel] Cleaning up the D-Bus interface In-Reply-To: <1135434294.1008.3.camel@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_67836_18979974.1138215267356" References: <1135111693.26233.11.camel@localhost> <3013cac80512211216r3918594dv676e03480d83f5b3@mail.gmail.com> <1135196479.3781.10.camel@localhost> <3013cac80512220511u9ecac97haf7278614bfe085a@mail.gmail.com> <1135271815.6002.96.camel@localhost> <3013cac80512230528y5b879d2bh2dbcb4e0fe18e974@mail.gmail.com> <1135350634.3985.2.camel@localhost> <1135434294.1008.3.camel@localhost> Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 25 Jan 2006 16:54:27 -0200 ------=_Part_67836_18979974.1138215267356 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi guys, This patch is based on your discussion, but there are some changes: 1. The scan enable values are based on the Bluetooth Spec in order to make the logic more clear: mode 0x00 =3D Off (means down or deep-sleep) mode 0x01 =3D Discoverable (NOT ALLOWED) mode 0x02 =3D Connectable mode 0x03 =3D Connectable and Discoverable 2. SetProperty/GetProperty can be used to set/get scan value According with the previous discussion, we can have both, but SetMode/GetMode is the preferred approach. This patch support only SetMode/GetMode. Support both approachs will make the code messy! Testing sample: //SetMode sample the allowed values are: 0, 2 and 3 $dbus-send --system --print-reply --dest=3Dorg.bluez /org/bluez/Device/hci0 org.bluez.Device.SetMode byte:0 //GetMode sample $dbus-send --system --print-reply --dest=3Dorg.bluez /org/bluez/Device/hci0 org.bluez.Device.GetMode The dbus-test python script can be used too. Regards, Claudio. On 12/24/05, Marcel Holtmann wrote: > Hi Eduardo, > > > > do you mean have both implementations (SetProperty("mode") and SetMod= e) ? > > > > we can have both, but I would prefer the SetMode() stuff. > > and if a device is in Connectable only mode it would be great if we have > another method that makes this device discoverable for a specific time. > For example make it discoverable for 3 minutes, like the early Ericsson > phones did. > > Regards > > Marcel > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log fi= les > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_id=3D7637&alloc_id=3D16865&op=3Dclick > _______________________________________________ > Bluez-devel mailing list > Bluez-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bluez-devel > -- --------------------------------------------------------- Claudio Takahasi Instituto Nokia de Tecnologia - INdT ------=_Part_67836_18979974.1138215267356 Content-Type: text/x-patch; name=scan01.patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="scan01.patch" --- bluez-utils-cvs.orig/hcid/dbus.h 2006-01-03 11:28:58.000000000 -0200 +++ bluez-utils-cvs-scan/hcid/dbus.h 2006-01-25 12:59:27.000000000 -0200 @@ -101,6 +101,7 @@ /* /org/bluez/Device signals */ #define BLUEZ_HCI_PROPERTY_CHANGED "PropertyChanged" +#define BLUEZ_HCI_SCAN_MODE_CHANGED "ModeChanged" /* Control interface signals */ #define BLUEZ_HCI_INQ_START "InquiryStart" @@ -125,6 +126,14 @@ #define DEV_DOWN "Down" #define DEV_SET_PROPERTY "SetProperty" #define DEV_GET_PROPERTY "GetProperty" +#define DEV_SET_MODE "SetMode" +#define DEV_GET_MODE "GetMode" + +/* SetMode constants, see Bluetooth spec write scan enable command section */ +#define MODE_SCAN_OFF SCAN_DISABLED +#define MODE_CONNECTABLE SCAN_PAGE +#define MODE_CONNECTABLE_DISCOVERABLE (SCAN_PAGE | SCAN_INQUIRY) + #define DEV_PROPERTY_AUTH "auth" #define DEV_PROPERTY_ENCRYPT "encrypt" @@ -136,7 +145,9 @@ #define DEV_UP_SIGNATURE __END_SIG__ #define DEV_DOWN_SIGNATURE __END_SIG__ -#define DEV_RESET_SIGNATURE __END_SIG__ +#define DEV_SET_MODE_SIGNATURE DBUS_TYPE_BYTE_AS_STRING\ + __END_SIG__ +#define DEV_GET_MODE_SIGNATURE __END_SIG__ #define DEV_SET_PROPERTY_SIGNATURE_BOOL DBUS_TYPE_STRING_AS_STRING \ DBUS_TYPE_BOOLEAN_AS_STRING \ __END_SIG__ --- bluez-utils-cvs.orig/hcid/dbus.c 2006-01-03 11:28:58.000000000 -0200 +++ bluez-utils-cvs-scan/hcid/dbus.c 2006-01-25 13:33:17.000000000 -0200 @@ -276,16 +276,18 @@ */ static DBusMessage* handle_device_up_req(DBusMessage *msg, void *data); static DBusMessage* handle_device_down_req(DBusMessage *msg, void *data); +static DBusMessage* handle_device_get_mode_req(DBusMessage *msg, void *data); +static DBusMessage* handle_device_set_mode_req(DBusMessage *msg, void *data); static DBusMessage* handle_device_set_property_req(DBusMessage *msg, void *data); static DBusMessage* handle_device_get_property_req(DBusMessage *msg, void *data); static DBusMessage* handle_device_set_property_req_name(DBusMessage *msg, void *data); static DBusMessage* handle_device_get_property_req_name(DBusMessage *msg, void *data); -static DBusMessage* handle_device_set_property_req_pscan(DBusMessage *msg, void *data); -static DBusMessage* handle_device_set_property_req_iscan(DBusMessage *msg, void *data); static const struct service_data device_services[] = { { DEV_UP, handle_device_up_req, DEV_UP_SIGNATURE }, { DEV_DOWN, handle_device_down_req, DEV_DOWN_SIGNATURE }, + { DEV_GET_MODE, handle_device_get_mode_req, DEV_GET_MODE_SIGNATURE }, + { DEV_SET_MODE, handle_device_set_mode_req, DEV_SET_MODE_SIGNATURE }, { DEV_SET_PROPERTY, handle_device_set_property_req, DEV_SET_PROPERTY_SIGNATURE_BOOL }, { DEV_SET_PROPERTY, handle_device_set_property_req, DEV_SET_PROPERTY_SIGNATURE_STR }, { DEV_SET_PROPERTY, handle_device_set_property_req, DEV_SET_PROPERTY_SIGNATURE_BYTE }, @@ -296,8 +298,6 @@ static const struct service_data set_property_services[] = { { DEV_PROPERTY_AUTH, handle_not_implemented_req, DEV_SET_PROPERTY_SIGNATURE_BOOL }, { DEV_PROPERTY_ENCRYPT, handle_not_implemented_req, DEV_SET_PROPERTY_SIGNATURE_BOOL }, - { DEV_PROPERTY_PSCAN, handle_device_set_property_req_pscan, DEV_SET_PROPERTY_SIGNATURE_BOOL }, - { DEV_PROPERTY_ISCAN, handle_device_set_property_req_iscan, DEV_SET_PROPERTY_SIGNATURE_BOOL }, { DEV_PROPERTY_NAME, handle_device_set_property_req_name, DEV_SET_PROPERTY_SIGNATURE_STR }, { DEV_PROPERTY_INCMODE, handle_not_implemented_req, DEV_SET_PROPERTY_SIGNATURE_BYTE }, { NULL, NULL, NULL} @@ -1993,6 +1993,82 @@ return reply; } +static DBusMessage* handle_device_get_mode_req(DBusMessage *msg, void *data) +{ + const struct hci_dbus_data *dbus_data = data; + DBusMessage *reply = NULL; + const uint8_t current_mode = dbus_data->path_data; + + reply = dbus_message_new_method_return(msg); + + dbus_message_append_args(reply, + DBUS_TYPE_BYTE, ¤t_mode, + DBUS_TYPE_INVALID); + + return reply; +} + +static DBusMessage* handle_device_set_mode_req(DBusMessage *msg, void *data) +{ + const struct hci_dbus_data *dbus_data = data; + DBusMessage *reply = NULL; + struct hci_request rq; + int dd = -1; + uint8_t mode = 0; + uint8_t status = 0; + const uint8_t current_mode = dbus_data->path_data; + + dbus_message_get_args(msg, NULL, + DBUS_TYPE_BYTE, &mode, + DBUS_TYPE_INVALID); + + if ((mode != MODE_SCAN_OFF) && (mode != MODE_CONNECTABLE) && + (mode != MODE_CONNECTABLE_DISCOVERABLE)) { + /* invalid mode */ + reply = bluez_new_failure_msg(msg, BLUEZ_EDBUS_WRONG_PARAM); + goto failed; + } + + dd = hci_open_dev(dbus_data->dev_id); + if (dd < 0) { + syslog(LOG_ERR, "HCI device open failed: hci%d", dbus_data->dev_id); + reply = bluez_new_failure_msg(msg, BLUEZ_ESYSTEM_ENODEV); + goto failed; + } + + /* Check if the new requested mode is different from the current */ + if (current_mode != mode) { + memset(&rq, 0, sizeof(rq)); + rq.ogf = OGF_HOST_CTL; + rq.ocf = OCF_WRITE_SCAN_ENABLE; + rq.cparam = &mode; + rq.clen = sizeof(mode); + rq.rparam = &status; + rq.rlen = sizeof(status); + + if (hci_send_req(dd, &rq, 100) < 0) { + syslog(LOG_ERR, "Sending write scan enable command failed: %s (%d)", + strerror(errno), errno); + reply = bluez_new_failure_msg(msg, BLUEZ_ESYSTEM_OFFSET | errno); + goto failed; + } + if (status) { + syslog(LOG_ERR, "Setting scan enable failed with status 0x%02x", status); + reply = bluez_new_failure_msg(msg, BLUEZ_EBT_OFFSET | status); + goto failed; + } + + } + + reply = dbus_message_new_method_return(msg); + +failed: + if (dd >= 0) + close(dd); + + return reply; +} + static DBusMessage* handle_device_set_property_req(DBusMessage *msg, void *data) { const struct service_data *handlers = set_property_services; @@ -2258,113 +2334,17 @@ return reply; } -static DBusMessage* write_scan_enable(DBusMessage *msg, void *data, gboolean ispscan) -{ - struct hci_dbus_data *dbus_data = data; - DBusMessageIter iter; - DBusMessage *reply = NULL; - int dd = -1; - read_scan_enable_rp rp; - uint8_t enable; - uint8_t status; - uint8_t scan_change, scan_keep; - struct hci_request rq; - gboolean prop_value; /* new requested value for the iscan or pscan */ - - dbus_message_iter_init(msg, &iter); - dbus_message_iter_next(&iter); - dbus_message_iter_get_basic(&iter, &prop_value); - - dd = hci_open_dev(dbus_data->dev_id); - if (dd < 0) { - syslog(LOG_ERR, "HCI device open failed: hci%d", dbus_data->dev_id); - reply = bluez_new_failure_msg(msg, BLUEZ_ESYSTEM_ENODEV); - goto failed; - } - - memset(&rq, 0, sizeof(rq)); - rq.ogf = OGF_HOST_CTL; - rq.ocf = OCF_READ_SCAN_ENABLE; - rq.rparam = &rp; - rq.rlen = READ_SCAN_ENABLE_RP_SIZE; - - if (hci_send_req(dd, &rq, 100) < 0) { - syslog(LOG_ERR, "Sending read scan enable command failed: %s (%d)", - strerror(errno), errno); - reply = bluez_new_failure_msg(msg, BLUEZ_ESYSTEM_OFFSET + errno); - goto failed; - } - - if (rp.status) { - syslog(LOG_ERR, "Getting scan enable failed with status 0x%02x", - rp.status); - reply = bluez_new_failure_msg(msg, BLUEZ_EBT_OFFSET + rp.status); - goto failed; - } - - if (ispscan) { /* Page scan */ - scan_change = SCAN_PAGE; - scan_keep = SCAN_INQUIRY; - } else { /* Inquiry scan */ - scan_change = SCAN_INQUIRY; - scan_keep = SCAN_PAGE; - } - - /* This is an optimization. We want to avoid overwrite the value - if the requested scan property will not change. */ - if (prop_value && !(rp.enable & scan_change)) - /* Enable the requested scan type (e.g. page scan). Keep the - the other type untouched. */ - enable = (rp.enable & scan_keep) | scan_change; - else if (!prop_value && (rp.enable & scan_change)) - /* Disable the requested scan type (e.g. page scan). Keep the - the other type untouched. */ - enable = (rp.enable & scan_keep); - else { /* Property not changed. Do nothing. Return ok. */ - reply = dbus_message_new_method_return(msg); - goto failed; - } - - memset(&rq, 0, sizeof(rq)); - rq.ogf = OGF_HOST_CTL; - rq.ocf = OCF_WRITE_SCAN_ENABLE; - rq.cparam = &enable; - rq.clen = sizeof(enable); - rq.rparam = &status; - rq.rlen = sizeof(status); - - if (hci_send_req(dd, &rq, 100) < 0) { - syslog(LOG_ERR, "Sending write scan enable command failed: %s (%d)", - strerror(errno), errno); - reply = bluez_new_failure_msg(msg, BLUEZ_ESYSTEM_OFFSET + errno); - goto failed; - } - if (status) { - syslog(LOG_ERR, "Setting scan enable failed with status 0x%02x", rp.status); - reply = bluez_new_failure_msg(msg, BLUEZ_EBT_OFFSET + rp.status); - goto failed; - } - reply = dbus_message_new_method_return(msg); - -failed: - if (dd >= 0) - close(dd); - return reply; - -} - void hcid_dbus_setscan_enable_complete(bdaddr_t *local) { - char *local_addr; + DBusMessage *message = NULL; char path[MAX_PATH_LENGTH]; + char *local_addr; bdaddr_t tmp; int id; int dd = -1; - gboolean se; read_scan_enable_rp rp; struct hci_request rq; struct hci_dbus_data *pdata = NULL; - uint32_t old_data; baswap(&tmp, local); local_addr = batostr(&tmp); id = hci_devid(local_addr); @@ -2405,39 +2385,39 @@ goto failed; } - old_data = pdata->path_data; + /* update the current scan mode value */ pdata->path_data = rp.enable; - /* If the new page scan flag is different from what we had, send a signal. */ - if((rp.enable & SCAN_PAGE) != (old_data & SCAN_PAGE)) { - se = (rp.enable & SCAN_PAGE); - send_property_changed_signal(id, DEV_PROPERTY_PSCAN, DBUS_TYPE_BOOLEAN, &se); - } - /* If the new inquity scan flag is different from what we had, send a signal. */ - if ((rp.enable & SCAN_INQUIRY) != (old_data & SCAN_INQUIRY)) { - se = (rp.enable & SCAN_INQUIRY); - send_property_changed_signal(id, DEV_PROPERTY_ISCAN, DBUS_TYPE_BOOLEAN, &se); + message = dbus_message_new_signal(path, DEVICE_INTERFACE, + BLUEZ_HCI_SCAN_MODE_CHANGED); + if (message == NULL) { + syslog(LOG_ERR, "Can't allocate D-BUS inquiry complete message"); + goto failed; } + dbus_message_append_args(message, + DBUS_TYPE_BYTE, &rp.enable, + DBUS_TYPE_INVALID); + + if (dbus_connection_send(connection, message, NULL) == FALSE) { + syslog(LOG_ERR, "Can't send D-BUS ModeChanged(%x) signal", rp.enable); + goto failed; + } + + dbus_connection_flush(connection); failed: + + if (message) + dbus_message_unref(message); + if (dd >= 0) close(dd); bt_free(local_addr); } -static DBusMessage* handle_device_set_property_req_pscan(DBusMessage *msg, void *data) -{ - return write_scan_enable(msg, data, TRUE); -} - -static DBusMessage* handle_device_set_property_req_iscan(DBusMessage *msg, void *data) -{ - return write_scan_enable(msg, data, FALSE); -} - static DBusMessage* handle_device_list_req(DBusMessage *msg, void *data) { DBusMessageIter iter; --- bluez-utils-cvs.orig/hcid/dbus-test 2005-12-24 10:45:37.000000000 -0200 +++ bluez-utils-cvs-scan/hcid/dbus-test 2006-01-25 11:10:38.000000000 -0200 @@ -9,10 +9,10 @@ from signal import * mgr_cmds = [ "DeviceList", "DefaultDevice" ] -dev_cmds = [ "Up", "Down", "SetProperty", "GetProperty", "Inquiry", +dev_cmds = [ "Up", "Down", "SetProperty", "GetProperty", "SetMode", "GetMode", "Inquiry", "CancelInquiry", "PeriodicInquiry","CancelPeriodic", "RemoteName", "Connections", "Authenticate", "RoleSwitch" ] -dev_setprop_bool = [ "auth", "encrypt", "discoverable", "connectable" ] +dev_setprop_bool = [ "auth", "encrypt" ] dev_setprop_byte = [ "incmode" ] dev_prop_filter = ["/org/bluez/Device/hci0", "/org/bluez/Device/hci1", "/org/bluez/Device/hci2", "/org/bluez/Device/hci3", @@ -88,6 +88,10 @@ self.bus.add_signal_receiver(self.dev_property_changed, 'PropertyChanged','org.bluez.Device', 'org.bluez',path) + for path in dev_prop_filter: + self.bus.add_signal_receiver(self.dev_mode_changed, + 'ModeChanged','org.bluez.Device', + 'org.bluez',path) obj = self.bus.get_object('org.bluez', '%s/Controller' % self.dev_path) self.ctl = dbus.Interface(obj, 'org.bluez.Device.Controller') @@ -166,11 +170,12 @@ dbus_message = keywords["dbus_message"] if property == 'name': print 'Device %s name changed: %s' % (dbus_message.get_path(), param) - elif property == 'connectable': - print 'Device %s connectable scan property changed: %d' % (dbus_message.get_path(), param) - elif property == 'discoverable': - print 'Device %s discoverable scan property changed: %d' % (dbus_message.get_path(), param) + @dbus.decorators.explicitly_pass_message + def dev_mode_changed(*args, **keywords): + mode = args[1] + dbus_message = keywords["dbus_message"] + print 'Device %s scan mode changed: %x' % (dbus_message.get_path(), mode) def signal_cb(self, sig, frame): print 'Caught signal, exiting' @@ -224,6 +229,25 @@ except dbus.DBusException, e: print 'Sending %s failed: %s' % (self.cmd, e) sys.exit(1) + elif self.cmd == 'SetMode': + if len(self.cmd_args) != 1: + print 'Usage: %s -i SetMode scan_enable' % self.name + print 'scan_enable values: 0(no scan), 2(connectable), 3(connectable and discoverable)' % self.name + sys.exit(1) + try: + print self.dev.SetMode(dbus.Byte(self.cmd_args[0])) + except dbus.DBusException, e: + print 'Sending %s failed: %s' % (self.cmd, e) + sys.exit(1) + elif self.cmd == 'GetMode': + if len(self.cmd_args) != 0: + print 'Usage: %s -i GetMode' % self.name + sys.exit(1) + try: + print self.dev.GetMode() + except dbus.DBusException, e: + print 'Sending %s failed: %s' % (self.cmd, e) + sys.exit(1) # Device.Controller methods elif self.cmd == 'Inquiry': try: ------=_Part_67836_18979974.1138215267356-- ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel