Message-ID: <45634AFC.909@vasmac.com>
Date: Tue, 21 Nov 2006 13:52:44 -0500
From: Jose Vasconcellos <jose@vasmac.com>
MIME-Version: 1.0
To: BlueZ development <bluez-devel@lists.sourceforge.net>
References: <455392B6.5060209@free.fr>
In-Reply-To: <455392B6.5060209@free.fr>
Subject: Re: [Bluez-devel] New bluetooth-headset release 20061109 : nickname
 'dogfood' ; -)
Reply-To: BlueZ development <bluez-devel@lists.sourceforge.net>
Content-Type: text/plain; charset="us-ascii"
Sender: bluez-devel-bounces@lists.sourceforge.net
Errors-To: bluez-devel-bounces@lists.sourceforge.net

Hi Fabien,

I have a minor suggestion regarding the binding of the unix
socket in daemon.c. Currently, the socket name registered
contains nul characters. It would be better to register the
name without the extra fill for monitoring applications.

Jose

--- daemon.c    2006-05-18 10:30:06.000000000 -0400
+++ ../../cvs/alsa-plugin-sco/headsetd/new/daemon.c    2006-09-01 
19:18:04.000000000 -0400
@@ -73,7 +73,7 @@
     struct sockaddr_un  pcm_srv_sock = {
         AF_UNIX, PCM_SERVER_SOCKET
     };
-    if(bind(_appl_srv_sockfd, (struct sockaddr *)&pcm_srv_sock, 
sizeof(pcm_srv_sock)) != 0) {
+    if(bind(_appl_srv_sockfd, (struct sockaddr *)&pcm_srv_sock, 
__SOCKADDR_COMMON_SIZE+sizeof(PCM_SERVER_SOCKET)-1) != 0) {
             syslog(LOG_ERR, "bind(_appl_srv_sockfd): %s", strerror(errno));
         goto error;   
     }
@@ -96,7 +96,7 @@
     struct sockaddr_un  ctl_srv_sock = {
         AF_UNIX, CTL_SERVER_SOCKET
     };
-    if(bind(_appl_ctlsrv_sockfd, (struct sockaddr *)&ctl_srv_sock, 
sizeof(ctl_srv_sock)) != 0) {
+    if(bind(_appl_ctlsrv_sockfd, (struct sockaddr *)&ctl_srv_sock, 
__SOCKADDR_COMMON_SIZE+sizeof(CTL_SERVER_SOCKET)-1) != 0) {
             syslog(LOG_ERR, "bind(_appl_ctlsrv_sockfd): %s", 
strerror(errno));
         goto error2;   
     }


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel