Return-Path: From: Marcel Holtmann To: BlueZ development In-Reply-To: <200611131114.43541.denis.kenzior@trolltech.com> References: <200610231025.51818.denis.kenzior@trolltech.com> <200611131114.43541.denis.kenzior@trolltech.com> Date: Mon, 13 Nov 2006 07:21:58 +0100 Message-Id: <1163398918.26272.11.camel@localhost> Mime-Version: 1.0 Subject: Re: [Bluez-devel] Proposed DTD Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net Hi Denis, > > this patch replaces string_t by sdp_buf_t and fix system bus > > disconnection problem. Check if this patch make sense or if it is > > better keep string_t. > > I agree we should replace string_t by sdp_buf_t since this avoids an extra > strlen. However, I think that the buffer should be grown by factors. Your > proposed solution would call realloc many times, as the append function is > called quite frequently with small strings, but this is no biggie. > > Would the attached patch be better? looks good to me. Claudio, please review it and then commit this to the CVS. Regards Marcel ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel