Return-Path: Message-ID: <462E21F0.4080204@vasmac.com> Date: Tue, 24 Apr 2007 09:27:44 -0600 From: Jose Vasconcellos MIME-Version: 1.0 To: BlueZ development References: <462E02FB.8000600@vasmac.com> In-Reply-To: Subject: Re: [Bluez-devel] [PATCH]Dynamic Alternate Setting patch (hci_usb.c) Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net list subscribe wrote: > Jose, > > Hi Alok, > > This is a good start. There are a few other things to consider: > > * Are there error conditions in hci_usb_tx_complete that need to > be handled? > > > I am not sure what you mean. Since we don't flush submitted URBs, > these URBs are handled like normal ones. If their status indicates > error the error_tx count will be incremented. What error conditions > are u pointing at? The outstanding urbs are dequeued and put on a temporary list and resubmitted after changing the configuration. But there may be an active URB that is being transmitted that will be reported with an error status. hci_usb_tx_complete will release this urb so it can't be resubmitted. This may also result in a small glitch when switching to an alternate. > > * How do you make sure data for different channels is interleaved? > > > Well , since we know that there can be max 3 SCO channels , we can > have 3 separate queues, and use a round robin method to send out the > packets from the queues. i am not sure about this idea though. What > do u think? I think this is the right approach; I found that it's very important to do the interleaving properly. There is an issue if one of the queues is empty (i.e. buffer underrun). What to do in that case? Send silence? Jose ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel