Return-Path: Message-ID: Date: Tue, 8 May 2007 09:05:39 -0700 From: "Satyam Sharma" To: "Jiri Kosina" Subject: Re: Getting make net/built-in.o Error with 2.6.21.1 Build Cc: chris@pcburn.com, linux-kernel@vger.kernel.org, "Marcel Holtmann" , bluez-devel@lists.sourceforge.net, netdev@vger.kernel.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <463FB6B0.3070005@pcburn.com> List-ID: Hi Jiri, On 5/8/07, Jiri Kosina wrote: > On Tue, 8 May 2007, Satyam Sharma wrote: > > > > CC init/version.o > > > LD init/built-in.o > > > LD .tmp_vmlinux1 > > > net/built-in.o: In function `hidp_add_connection': > > > (.text+0x8bb08): undefined reference to `hid_ff_init' > > > make: *** [.tmp_vmlinux1] Error 1 > > You've got CONFIG_BT_HIDP=y there but CONFIG_USB_HID=m. The trivial > > patch below solves it. To test, you can just "make oldconfig" on the > > same .config that broke above and then proceed to make bzImage. > > I'd say we need a different fix here. First, the question is whether there > are any force-feedback devices, supported by USBHID force-feedback layer, > which have a bluetooth version? > > If there are none of them, we could just drop the FF initialization > completely for now. > > On the other hand if there are such devices, just calling hid_ff_init() is > presently not enough anyway, as the force feedback drivers for HID devices > are currently USB-transport specific. Sure, my aim here was to only solve the _build breakage_ by fixing the Kconfig for this module (that used code from another kernel module without listing it in its dependencies). If, as you say, the real solution is that we should actually be taking out the offending call to the other module itself, then please go ahead -- I don't know much about the Bluetooth / HIDP subsytem anyway. Thanks, Satyam