Return-Path: Message-ID: <5f84803c0712171247t7879a8adp6d17981697396527@mail.gmail.com> Date: Mon, 17 Dec 2007 15:47:57 -0500 From: "Chris Rivera" To: "BlueZ development" In-Reply-To: <1197922624.8050.107.camel@aeonflux> MIME-Version: 1.0 References: <5f84803c0712030733q38350283m77e8930dfcca4162@mail.gmail.com> <1196699122.12292.113.camel@violet> <5f84803c0712030850k5810ee43na4a13f5e74657388@mail.gmail.com> <1196701181.12292.128.camel@violet> <5f84803c0712060959n6db58e78y4adfa1b4a212df71@mail.gmail.com> <1197870459.8050.80.camel@aeonflux> <5f84803c0712170754n14d401a7l225d3d9b2f413850@mail.gmail.com> <1197917583.8050.87.camel@aeonflux> <5f84803c0712171129o770c38e5g35d57dea64be94f5@mail.gmail.com> <1197922624.8050.107.camel@aeonflux> Subject: Re: [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1689733811==" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net --===============1689733811== Content-Type: multipart/alternative; boundary="----=_Part_11653_8706313.1197924478033" ------=_Part_11653_8706313.1197924478033 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Dec 17, 2007 3:17 PM, Marcel Holtmann wrote: > > I think that is simply too complicated. If we use --singleton, it all > has to come into place. And if D-Bus fails, the application is not good > anyway. So I don't see the real benefit. If at any time later it will be > needed, we can introduce it then. > Agreed. > > Please use use gtk_init_with_args and make the GOptionEntry data global > and static. Look at bluetooth-analyzer for an example. > This would force the singleton flag variable to be global. Is this what you want? > > Also don't translate config options and errors that are printed on the > command line. We only translate stuff inside the UI. The normal user > won't see these anyway. > > OK. Chris ------=_Part_11653_8706313.1197924478033 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Dec 17, 2007 3:17 PM, Marcel Holtmann <marcel@holtmann.org> wrote:

I think that is simply too complicated. If we use --singleton, it all
has to come into place. And if D-Bus fails, the application is not good
anyway. So I don't see the real benefit. If at any time later it will be
needed, we can introduce it then.

Agreed.
 

Please use use gtk_init_with_args and make the GOptionEntry data global
and static. Look at bluetooth-analyzer for an example.

This would force the singleton flag variable to be global.  Is this what you want?
 

Also don't translate config options and errors that are printed on the
command line. We only translate stuff inside the UI. The normal user
won't see these anyway.


OK.

Chris ------=_Part_11653_8706313.1197924478033-- --===============1689733811== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace --===============1689733811== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel --===============1689733811==--