Return-Path: Date: Wed, 16 Jan 2008 03:52:24 +0000 From: Al Viro To: Linus Torvalds Cc: Tejun Heo , Linux Kernel , Gabor Gombas , Greg KH , Dave Young , bluez-devel@lists.sourceforge.net Subject: Re: [PATCH 2.6.24-rc7 2/2] sysfs: fix bugs in sysfs_rename/move_dir() Message-ID: <20080116035224.GW27894@ZenIV.linux.org.uk> References: <478D74A6.7000206@gmail.com> <478D75BD.1010805@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Tue, Jan 15, 2008 at 07:41:58PM -0800, Linus Torvalds wrote: > and wonder what happen sif old_parent == new_parent. Is that trying to > avoid an ABBA deadlock? Normally you'd do it by ordering the locks, or by > taking a third lock to guarantee serialization at a higher level (ie the > "s_vfs_rename_mutex" on the VFS layer) > > I'd like to apply these two patches, but I really want to get more of an > ack for them from somebody like Al, or at least more of an explanation for > why it's all the right thing. No ACK is coming until we get something resembling analysis of locking scheme. Which won't happen until we at least get the "what callers are allowed to do" written down, damnit. As it is, I'm more than inclined to propose ripping kobject_move() out, especially since it has only two users - something s390-specific and rfcomm, with its shitloads of problems beyond just sysfs interaction.