Return-Path: Message-Id: <9C4A112D-DB33-4C90-8A80-5B5400155016@gmail.com> From: Johan Hedberg To: BlueZ development In-Reply-To: Mime-Version: 1.0 (Apple Message framework v919.2) Date: Fri, 29 Feb 2008 21:31:02 +0200 References: <47C7D90A.9020306@access-company.com> Subject: Re: [Bluez-devel] [patch] alignment trap in hcid Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net On Feb 29, 2008, at 20:27, Marcel Holtmann wrote: >> I recently met an alignment trap in hcid. >> Some device sent me an sdp request and the answer had to be >> fragmented because the device reception buffer was very small. >> After that i saw alignment trap. >> The last trace I saw was : Continuation state size: 8 >> The trace is located at sdpd/request.c : static sdp_cont_state_t >> *sdp_cstate_get(uint8_t *buffer) >> This function returns an unaligned pointer. > > this is so funny since I know it was there, but the new qualification > tests don't find it anymore :) > > Please fix the coding style. You are missing some spaces after the > "if". > > Johan, please have second look at the patch. It looks good to me. Looks good to me too. Johan ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel