Return-Path: From: Marcel Holtmann To: BlueZ development In-Reply-To: <35c90d960808300132t959e1difc2d8f4c0eca0f95@mail.gmail.com> References: <1220050803-30362-1-git-send-email-npelly@google.com> <1220086722.7145.33.camel@californication> <35c90d960808300016t1ea8b8eq638a399e7d04b1e9@mail.gmail.com> <1220088521.7145.51.camel@californication> <35c90d960808300037h242dbf5fkd584bf552ed50190@mail.gmail.com> <1220090659.7145.71.camel@californication> <35c90d960808300132t959e1difc2d8f4c0eca0f95@mail.gmail.com> Date: Sat, 30 Aug 2008 12:46:37 +0200 Message-Id: <1220093197.7145.81.camel@californication> Mime-Version: 1.0 Subject: Re: [Bluez-devel] [PATCH] Advertise Telephony service class when device offers headset AG or handsfree AG Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net Hi Nick, > >> So I looked at the headset and handsfree spec, they do not require > >> that AG's set the telephony bit. sigh. > >> > >> But I can tell you for a fact that the Nokia 616 carkit will not pair > >> unless you set the telephony bit. That is what triggered this patch. > > > > that looks like a really broken device to me. How can it pass the > > qualification if it mandates that bit. Is PTS setting it by accident. > > > >> We have yet to find a device (and we have tested hundreds now) that is > >> not compatible because of the telephony bit. It is a safe change to > >> make. > > > > Check your patch with PTS headset/handsfree and the IOP part. > > Yeah thats worth checking. I can't check until Wednesday when I am > back in the office with the PTS tester. I'll post back results. you can also file an errata to have the headset and handsfree specification fixed. If they agree that the telephony bit should been set. > > I am not > > sure if we can just enable service bits as we like. > > > > So in case I can be convinced to take this patch, it has to be in a > > separate case statement and with a comment that the Nokia 616 is just a > > plain stupid broken device and that is why we did it. The spec. doesn't > > mandate this. > > > > I also realized that the Nokia 616 might just is lucky in the interop > > department since most phones also implement DUN, FAX or SAP and thus the > > telephony bit is set. > > > > This brings me to another question, why don't you just use the serial > > proxy support we have and point it to one of the multiplexed TTYs of > > your GSM unit. Then you get DUN support and that broken Nokia device > > would also work :) > > I wish, but this is not an option for us. That might be actually the reason why the Nokia 616 is so stupid. They only tested it with phones that also implement DUN or SAP. And you can still contact Nokia and point them to the headset/handsfree specs. for this issue. > > So what about the desktop case that enables HS-AG and HF-AG? Are these > > phones? Does headset profile really mean that you have to be phone. Not > > likely. With the GSM requirements of handsfree, maybe. > > Both HSP and HFP are intended for telephony. I can't see any harm in > the desktop case in setting the telephony bit, after all it will let > them work with the Nokia 616. It is really not about harm or not. We have to make sure to be compliant here. The service class bits are not the brightest that the SIG ever produced, but at least the specs. are pretty clear when to set them and when not. If other companies would finally implement Simple Pairing and thus be allowed to enable Extended Inquiry Response, then this problem would finally go away. With EIR you get the UUID and can easily identify which service is available. Did I mention that BlueZ does already support Simple Pairing and Extended Inquiry Response :) And don't try to convince me for the headset case. I am not fixing that one. The spec. says here what it says. For the handsfree we can debate this, but currently I am in a more restrictive mode and push back on what the spec. says. It is up to you to proof that this will not break other application or profile qualification. Regards Marcel ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel