Received-SPF: pass (google.com: domain of oss-security-return-30111-linux.lists.archive=gmail.com@lists.openwall.com designates 193.110.157.125 as permitted sender) client-ip=193.110.157.125;
Mailing-List: contact oss-security-help@lists.openwall.com; run by ezmlm
Precedence: bulk
Reply-To: oss-security@lists.openwall.com
Feedback-ID: ie6294588:Fastmail
Message-ID: <4a05754d4e8f49b8f1ce5dcacb91c2c44a8e1252.camel@sambull.org>
From: Sam Bull <9m199i@sambull.org>
To: oss-security@lists.openwall.com
Date: Thu, 02 May 2024 14:48:19 +0100
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-c99SIr8BiZ5NDGs3tXuw"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Subject: [oss-security] CVE-2024-30251: DoS in aiohttp

--=-c99SIr8BiZ5NDGs3tXuw
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Aiohttp is an HTTP client and server-side web framework in Python. This iss=
ue only affects
users of the server-side web framework. We've not seen any evidence of this=
 being
exploited in the wild yet, and fixes were already included in the 3.9.4 and=
 3.9.5
releases.

https://github.com/aio-libs/aiohttp/security/advisories/GHSA-5m98-qgg9-wh84

### Summary
An attacker can send a specially crafted POST (multipart/form-data) request=
. When the
aiohttp server processes it, the server will enter an infinite loop and be =
unable to
process any further requests.

### Impact
An attacker can stop the application from serving requests after sending a =
single request.

-------

For anyone needing to patch older versions of aiohttp, the minimum diff nee=
ded to resolve
the issue is (located in `_read_chunk_from_length()`):

   diff --git a/aiohttp/multipart.py b/aiohttp/multipart.py
   index 227be605c..71fc2654a 100644
   --- a/aiohttp/multipart.py
   +++ b/aiohttp/multipart.py
   @@ -338,6 +338,8 @@ class BodyPartReader:
            assert self._length is not None, "Content-Length required for c=
hunked read"
            chunk_size =3D min(size, self._length - self._read_bytes)
            chunk =3D await self._content.read(chunk_size)
   +        if self._content.at_eof():
   +            self._at_eof =3D True
            return chunk
   =20
        async def _read_chunk_from_stream(self, size: int) -> bytes:

This does however introduce some very minor issues with handling form data.=
 So, if
possible, it would be recommended to also backport the changes in:
https://github.com/aio-libs/aiohttp/commit/cebe526b9c34dc3a3da9140409db6301=
4bc4cf19
https://github.com/aio-libs/aiohttp/commit/7eecdff163ccf029fbb1ddc9de4169d4=
aaeb6597
https://github.com/aio-libs/aiohttp/commit/f21c6f2ca512a026ce7f0f6c6311f62d=
6a638866

--=-c99SIr8BiZ5NDGs3tXuw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS7LDpjuw7VQ6ct5tdf6SjNlibOKwUCZjOZowAKCRBf6SjNlibO
K4P+AKDIimVAc4kdyfd/cLcHg+f5dNAAnwCfbkyGLTyPZtxI0p1uocWpUqNnqYM=
=xQTM
-----END PGP SIGNATURE-----

--=-c99SIr8BiZ5NDGs3tXuw--