2008-11-11 01:20:26

by Adrian-Ken Rueegsegger

Subject: [PATCH] libcrc32c: Fix "crc32c undefined" compilation error

The latest shash changes leave crc32c undefined:

[...]
Building modules, stage 2.
MODPOST 1381 modules
ERROR: "crc32c" [net/sctp/sctp.ko] undefined!
ERROR: "crc32c" [net/ipv4/netfilter/nf_nat_proto_sctp.ko] undefined!

Adding EXPORT_SYMBOL(crc32c) to lib/libcrc32c.c fixes the compile error.
This patch has been compile-tested only.

Signed-off-by: Adrian-Ken Rueegsegger <[email protected]>
---
lib/libcrc32c.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/libcrc32c.c b/lib/libcrc32c.c
index 38b17ab..244f548 100644
--- a/lib/libcrc32c.c
+++ b/lib/libcrc32c.c
@@ -57,6 +57,8 @@ u32 crc32c(u32 crc, const void *address, unsigned int length)
return *(u32 *)desc.ctx;
}

+EXPORT_SYMBOL(crc32c);
+
static int __init libcrc32c_mod_init(void)
{
tfm = crypto_alloc_shash("crc32c", 0, 0);
--
1.5.4.3

2008-11-11 04:15:19

by Herbert Xu

Subject: Re: [PATCH] libcrc32c: Fix "crc32c undefined" compilation error

On Tue, Nov 11, 2008 at 01:59:26AM +0100, Adrian-Ken Rueegsegger wrote:
> The latest shash changes leave crc32c undefined:
>
> [...]
> Building modules, stage 2.
> MODPOST 1381 modules
> ERROR: "crc32c" [net/sctp/sctp.ko] undefined!
> ERROR: "crc32c" [net/ipv4/netfilter/nf_nat_proto_sctp.ko] undefined!

Thanks for fixing this Adrian! I've applied to cryptodev.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt