2011-02-21 14:27:37

by David Sterba

Subject: [PATCH] crypto: do not attempt to write to readonly variable

Commit da7f033ddc9fdeb (”crypto: cryptomgr - Add test infrastructure”) added a
const to variable which is later used as target buffer of memcpy.

crypto/tcrypt.c:217:12: warning: passing 'const char (*)[128]' to parameter of type 'void *' discards qualifiers
memset(&iv, 0xff, iv_len);


crypto/tcrypt.c:test_cipher_speed()

- unsigned char *key, iv[128];
+ const char *key, iv[128];
...
memset(&iv, 0xff, iv_len);

CC: Herbert Xu <[email protected]>
Signed-off-by: David Sterba <[email protected]>
---
crypto/tcrypt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index 9aac5e5..e912ea5 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -146,7 +146,8 @@ static void test_cipher_speed(const char *algo, int enc, unsigned int sec,
unsigned int tcount, u8 *keysize)
{
unsigned int ret, i, j, iv_len;
- const char *key, iv[128];
+ const char *key;
+ char iv[128];
struct crypto_blkcipher *tfm;
struct blkcipher_desc desc;
const char *e;
--
1.7.4

2011-03-04 07:29:24

by Herbert Xu

Subject: Re: [PATCH] crypto: do not attempt to write to readonly variable

On Mon, Feb 21, 2011 at 03:27:22PM +0100, David Sterba wrote:
> Commit da7f033ddc9fdeb (”crypto: cryptomgr - Add test infrastructure”) added a
> const to variable which is later used as target buffer of memcpy.

Patch applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt