2012-04-14 20:48:48

by Julia Lawall

Subject: [PATCH] drivers/crypto/amcc/crypto4xx_core.c: move up err_request_irq label

From: Julia Lawall <[email protected]>

Move the err_request_irq error label up to reflect that tasklet_init and
irq_of_parse_and_map have taken place.

Signed-off-by: Julia Lawall <[email protected]>

---
drivers/crypto/amcc/crypto4xx_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c
index 13f8e1a..802e851 100644
--- a/drivers/crypto/amcc/crypto4xx_core.c
+++ b/drivers/crypto/amcc/crypto4xx_core.c
@@ -1244,9 +1244,9 @@ err_start_dev:
iounmap(core_dev->dev->ce_base);
err_iomap:
free_irq(core_dev->irq, dev);
+err_request_irq:
irq_dispose_mapping(core_dev->irq);
tasklet_kill(&core_dev->tasklet);
-err_request_irq:
crypto4xx_destroy_sdr(core_dev->dev);
err_build_sdr:
crypto4xx_destroy_gdr(core_dev->dev);

2012-04-27 01:32:04

by Herbert Xu

Subject: Re: [PATCH] drivers/crypto/amcc/crypto4xx_core.c: move up err_request_irq label

On Sat, Apr 14, 2012 at 10:48:41PM +0200, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> Move the err_request_irq error label up to reflect that tasklet_init and
> irq_of_parse_and_map have taken place.
>
> Signed-off-by: Julia Lawall <[email protected]>

Patch applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt