2012-09-27 22:44:14

by Tim Chen

Subject: [PATCH 0/3 v2] Optimize CRC32C calculation using PCLMULQDQ in crc32c-intel module

Version 2
This version of the patch series fixes compilation errors for
32 bit x86 targets.

Version 1
This patch series optimized CRC32C calculations with PCLMULQDQ
instruction for crc32c-intel module. It speeds up the original
implementation by 1.6x for 1K buffer and by 3x for buffer 4k or
more. The tcrypt module was enhanced for doing speed test
on crc32c calculations.

Tim

Signed-off-by: Tim Chen <[email protected]>
---

Tim Chen (3):
Rename crc32c-intel.c to crc32c-intel_glue.c
Optimize CRC32C calculation with PCLMULQDQ instruction
Added speed test in tcrypt for crc32c

arch/x86/crypto/Makefile | 2 +
.../crypto/{crc32c-intel.c => crc32c-intel_glue.c} | 81 ++++
arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 460 ++++++++++++++++++++
crypto/Kconfig | 10 +
crypto/tcrypt.c | 4 +
5 files changed, 557 insertions(+), 0 deletions(-)
rename arch/x86/crypto/{crc32c-intel.c => crc32c-intel_glue.c} (69%)
create mode 100644 arch/x86/crypto/crc32c-pcl-intel-asm_64.S

--
1.7.7.6

2012-09-28 02:54:37

by H. Peter Anvin

Subject: Re: [PATCH 0/3 v2] Optimize CRC32C calculation using PCLMULQDQ in crc32c-intel module

On 09/27/2012 03:44 PM, Tim Chen wrote:
> Version 2
> This version of the patch series fixes compilation errors for
> 32 bit x86 targets.
>
> Version 1
> This patch series optimized CRC32C calculations with PCLMULQDQ
> instruction for crc32c-intel module. It speeds up the original
> implementation by 1.6x for 1K buffer and by 3x for buffer 4k or
> more. The tcrypt module was enhanced for doing speed test
> on crc32c calculations.
>

Herbert - you are handling this one, right?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

2012-10-05 16:47:46

by Tim Chen

Subject: Re: [PATCH 0/3 v2] Optimize CRC32C calculation using PCLMULQDQ in crc32c-intel module

On Fri, 2012-09-28 at 10:57 +0800, Herbert Xu wrote:
> 在 2012-9-28 上午10:54，"H. Peter Anvin" <[email protected]>写道：
> >
> > On 09/27/2012 03:44 PM, Tim Chen wrote:
> >>
> >> Version 2
> >> This version of the patch series fixes compilation errors for
> >> 32 bit x86 targets.
> >>
> >> Version 1
> >> This patch series optimized CRC32C calculations with PCLMULQDQ
> >> instruction for crc32c-intel module. It speeds up the original
> >> implementation by 1.6x for 1K buffer and by 3x for buffer 4k or
> >> more. The tcrypt module was enhanced for doing speed test
> >> on crc32c calculations.
> >>
> >
> > Herbert - you are handling this one, right?
>
> Yes thanks
>
>

Hi Herbert, are there any other changes I should do on my end? Is
the patchset ready to be picked up in crypto-dev?

Thanks.

Tim

2012-10-15 14:32:23

by Herbert Xu

Subject: Re: [PATCH 0/3 v2] Optimize CRC32C calculation using PCLMULQDQ in crc32c-intel module

On Thu, Sep 27, 2012 at 03:44:14PM -0700, Tim Chen wrote:
> Version 2
> This version of the patch series fixes compilation errors for
> 32 bit x86 targets.
>
> Version 1
> This patch series optimized CRC32C calculations with PCLMULQDQ
> instruction for crc32c-intel module. It speeds up the original
> implementation by 1.6x for 1K buffer and by 3x for buffer 4k or
> more. The tcrypt module was enhanced for doing speed test
> on crc32c calculations.
>
> Tim
>
> Signed-off-by: Tim Chen <[email protected]>

All applied. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt