2013-05-03 09:31:12

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH 1/2] crypto: mv_cesa: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <[email protected]>
Cc: Sebastian Andrzej Siewior <[email protected]>
---
drivers/crypto/mv_cesa.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
index ce6290e..3374a3e 100644
--- a/drivers/crypto/mv_cesa.c
+++ b/drivers/crypto/mv_cesa.c
@@ -1146,7 +1146,6 @@ err_unmap_reg:
err:
kfree(cp);
cpg = NULL;
- platform_set_drvdata(pdev, NULL);
return ret;
}

--
1.7.9.5


2013-05-03 09:31:16

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH 2/2] crypto: s5p-sss: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <[email protected]>
Cc: Vladimir Zapolskiy <[email protected]>
---
drivers/crypto/s5p-sss.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 4b31432..cf149b1 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -647,7 +647,6 @@ static int s5p_aes_probe(struct platform_device *pdev)
clk_disable(pdata->clk);

s5p_dev = NULL;
- platform_set_drvdata(pdev, NULL);

return err;
}
@@ -668,7 +667,6 @@ static int s5p_aes_remove(struct platform_device *pdev)
clk_disable(pdata->clk);

s5p_dev = NULL;
- platform_set_drvdata(pdev, NULL);

return 0;
}
--
1.7.9.5

2013-05-14 02:36:16

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 1/2] crypto: mv_cesa: Remove redundant platform_set_drvdata()

On Fri, May 03, 2013 at 02:48:14PM +0530, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> Cc: Sebastian Andrzej Siewior <[email protected]>

Both patches applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt