2020-04-27 09:50:15

by Hadar Gat

Subject: [PATCH v2 0/3] hwrng: cctrng kconfig updates

Some fixes in Kconfig for cctrng:
+ add missing dependency on OF
+ change default to 'n'
+ improve inaccurate help description

v2 changes:
+ remove unneeded depends on HW_RANDOM.
+ remove unneeded line 'default n' in order to follow the convention.
+ in help description changed to: If unsure, say 'N'

Hadar Gat (3):
hwrng: cctrng - Add dependency on OF
hwrng: cctrng - change default to n
hwrng: cctrng - update help description

drivers/char/hw_random/Kconfig | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

--
2.7.4

2020-04-27 09:50:28

by Hadar Gat

Subject: [PATCH v2 1/3] hwrng: cctrng - Add dependency on OF

The cctrng is unusable on non-DT systems so we should depend
on it.

Signed-off-by: Hadar Gat <[email protected]>
---
drivers/char/hw_random/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 0c99735..df2d001 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -476,7 +476,7 @@ config HW_RANDOM_KEYSTONE

config HW_RANDOM_CCTRNG
tristate "Arm CryptoCell True Random Number Generator support"
- depends on HAS_IOMEM
+ depends on HAS_IOMEM & OF
default HW_RANDOM
help
This driver provides support for the True Random Number
--
2.7.4

2020-04-27 09:51:06

by Hadar Gat

Subject: [PATCH v2 3/3] hwrng: cctrng - update help description

Improved the HW_RANDOM_CCTRNG help description.

Signed-off-by: Hadar Gat <[email protected]>
---
drivers/char/hw_random/Kconfig | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index fc8bb31..d53470d 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -478,13 +478,14 @@ config HW_RANDOM_CCTRNG
tristate "Arm CryptoCell True Random Number Generator support"
depends on HAS_IOMEM & OF
help
- This driver provides support for the True Random Number
- Generator available in Arm TrustZone CryptoCell.
-
- To compile this driver as a module, choose M here: the module
+ Say 'Y' to enable the True Random Number Generator driver for the
+ Arm TrustZone CryptoCell family of processors.
+ Currently the CryptoCell 713 and 703 are supported.
+ The driver is supported only in SoC where Trusted Execution
+ Environment is not used.
+ Choose 'M' to compile this driver as a module. The module
will be called cctrng.
-
- If unsure, say Y.
+ If unsure, say 'N'.

endif # HW_RANDOM

--
2.7.4

2020-04-27 10:32:03

by Herbert Xu

Subject: Re: [PATCH v2 1/3] hwrng: cctrng - Add dependency on OF

On Mon, Apr 27, 2020 at 12:49:04PM +0300, Hadar Gat wrote:
> The cctrng is unusable on non-DT systems so we should depend
> on it.
>
> Signed-off-by: Hadar Gat <[email protected]>
> ---
> drivers/char/hw_random/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This breaks compile testing for me so nack.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2020-04-27 11:15:16

by Hadar Gat

Subject: RE: [PATCH v2 1/3] hwrng: cctrng - Add dependency on OF

> -----Original Message-----
> From: [email protected] <linux-crypto-
> [email protected]> On Behalf Of Herbert Xu
>
> On Mon, Apr 27, 2020 at 12:49:04PM +0300, Hadar Gat wrote:
> > The cctrng is unusable on non-DT systems so we should depend on it.
> >
> > Signed-off-by: Hadar Gat <[email protected]>
> > ---
> > drivers/char/hw_random/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This breaks compile testing for me so nack.

Oops.. Fixed this in v3.

Hadar

> --
> Email: Herbert Xu <[email protected]> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt