2022-11-21 11:13:14

by wangyufen

Subject: [PATCH] crypto: qat - fix error return code in adf_probe

Fix to return a negative error code -EINVAL instead of 0.

Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
Signed-off-by: Wang Yufen <[email protected]>
---
drivers/crypto/qat/qat_4xxx/adf_drv.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/qat/qat_4xxx/adf_drv.c b/drivers/crypto/qat/qat_4xxx/adf_drv.c
index 2f21256..670a58b2 100644
--- a/drivers/crypto/qat/qat_4xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_4xxx/adf_drv.c
@@ -261,6 +261,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
hw_data->accel_capabilities_mask = hw_data->get_accel_cap(accel_dev);
if (!hw_data->accel_capabilities_mask) {
dev_err(&pdev->dev, "Failed to get capabilities mask.\n");
+ ret = -EINVAL;
goto out_err;
}

--
1.8.3.1

2022-11-21 12:00:08

by Cabiddu, Giovanni

Subject: Re: [PATCH] crypto: qat - fix error return code in adf_probe

On Mon, Nov 21, 2022 at 07:27:34PM +0800, Wang Yufen wrote:
> Fix to return a negative error code -EINVAL instead of 0.
>
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Wang Yufen <[email protected]>
Acked-by: Giovanni Cabiddu <[email protected]>

2022-12-02 10:20:13

by Herbert Xu

Subject: Re: [PATCH] crypto: qat - fix error return code in adf_probe

On Mon, Nov 21, 2022 at 07:27:34PM +0800, Wang Yufen wrote:
> Fix to return a negative error code -EINVAL instead of 0.
>
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Wang Yufen <[email protected]>
> ---
> drivers/crypto/qat/qat_4xxx/adf_drv.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt