2007-07-15 10:00:50

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] drivers/crypto/Kconfig: hardware drivers shouldn't "default m"

Hardware drivers shouldn't default to m.

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/crypto/Kconfig | 5 -----
1 file changed, 5 deletions(-)

--- linux-2.6.22-rc6-mm1/drivers/crypto/Kconfig.old 2007-07-14 06:25:27.000000000 +0200
+++ linux-2.6.22-rc6-mm1/drivers/crypto/Kconfig 2007-07-14 06:25:35.000000000 +0200
@@ -8,7 +8,6 @@
tristate "Support for VIA PadLock ACE"
depends on X86_32
select CRYPTO_ALGAPI
- default m
help
Some VIA processors come with an integrated crypto engine
(so called VIA PadLock ACE, Advanced Cryptography Engine)
@@ -22,7 +21,6 @@
tristate "PadLock driver for AES algorithm"
depends on CRYPTO_DEV_PADLOCK
select CRYPTO_BLKCIPHER
- default m
help
Use VIA PadLock for AES algorithm.

@@ -36,7 +34,6 @@
depends on CRYPTO_DEV_PADLOCK
select CRYPTO_SHA1
select CRYPTO_SHA256
- default m
help
Use VIA PadLock for SHA1/SHA256 algorithms.

@@ -52,7 +49,6 @@
depends on X86_32 && PCI
select CRYPTO_ALGAPI
select CRYPTO_BLKCIPHER
- default m
help
Say 'Y' here to use the AMD Geode LX processor on-board AES
engine for the CryptoAPI AES algorithm.
@@ -64,7 +60,6 @@
tristate "Support for PCI-attached cryptographic adapters"
depends on S390
select ZCRYPT_MONOLITHIC if ZCRYPT="y"
- default "m"
help
Select this option if you want to use a PCI-attached cryptographic
adapter like:


2007-07-17 12:33:43

by Herbert Xu

[permalink] [raw]
Subject: Re: [2.6 patch] drivers/crypto/Kconfig: hardware drivers shouldn't "default m"

On Sun, Jul 15, 2007 at 12:00:13PM +0200, Adrian Bunk wrote:
> Hardware drivers shouldn't default to m.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Applied.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt