This patch fixes a couple of minor issues found by J. Bruce Fields
while reviewing with the CTS mode patch already applied.
It also changes the license to "Dual BSD/GPL".
Signed-off-by: Kevin Coffman <[email protected]>
---
crypto/cts.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/crypto/cts.c b/crypto/cts.c
index 6fe968a..c4e70bf 100644
--- a/crypto/cts.c
+++ b/crypto/cts.c
@@ -201,7 +201,7 @@ static int cts_cbc_decrypt(struct crypto_cts_ctx *ctx,
sg_set_buf(&sgdst[0], d, bsize);
err = crypto_blkcipher_decrypt_iv(&lcldesc, sgdst, sgsrc, bsize);
- /* XXX xor with previous block ?? */
+ /* XOR with previous block */
crypto_xor(d, desc->info, bsize);
scatterwalk_map_and_copy(d, dst, offset, nbytes, 1);
@@ -343,5 +343,5 @@ static void __exit crypto_cts_module_exit(void)
module_init(crypto_cts_module_init);
module_exit(crypto_cts_module_exit);
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("CTS-CBC) CipherText Stealing for CBC");
+MODULE_LICENSE("Dual BSD/GPL");
+MODULE_DESCRIPTION("CTS-CBC CipherText Stealing for CBC");
* Kevin Coffman | 2008-03-31 14:39:13 [-0400]:
>This patch fixes a couple of minor issues found by J. Bruce Fields
>while reviewing with the CTS mode patch already applied.
>
There is no functional change in your patch. Did you forget something
or is this on purpose? I assume "a couple of minor issues" is > 1 :)
>---
>
> crypto/cts.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/crypto/cts.c b/crypto/cts.c
>index 6fe968a..c4e70bf 100644
>--- a/crypto/cts.c
>+++ b/crypto/cts.c
>@@ -201,7 +201,7 @@ static int cts_cbc_decrypt(struct crypto_cts_ctx *ctx,
> sg_set_buf(&sgdst[0], d, bsize);
> err = crypto_blkcipher_decrypt_iv(&lcldesc, sgdst, sgsrc, bsize);
>
>- /* XXX xor with previous block ?? */
>+ /* XOR with previous block */
> crypto_xor(d, desc->info, bsize);
>
> scatterwalk_map_and_copy(d, dst, offset, nbytes, 1);
Sebastian
On Mon, Mar 31, 2008 at 3:24 PM, Sebastian Siewior
<[email protected]> wrote:
> * Kevin Coffman | 2008-03-31 14:39:13 [-0400]:
>
>
> >This patch fixes a couple of minor issues found by J. Bruce Fields
> >while reviewing with the CTS mode patch already applied.
> >
> There is no functional change in your patch.
agreed.
> Did you forget something
> or is this on purpose? I assume "a couple of minor issues" is > 1 :)
OK, lets call them a couple of minor nits/typos ?
K.C.
* Kevin Coffman | 2008-03-31 15:27:30 [-0400]:
>> Did you forget something
>> or is this on purpose? I assume "a couple of minor issues" is > 1 :)
>
>OK, lets call them a couple of minor nits/typos ?
No problem. Just trying to ensure you did not forget anything.
>K.C.
Sebastian
On Mon, Mar 31, 2008 at 02:39:13PM -0400, Kevin Coffman wrote:
> This patch fixes a couple of minor issues found by J. Bruce Fields
> while reviewing with the CTS mode patch already applied.
>
> It also changes the license to "Dual BSD/GPL".
>
> Signed-off-by: Kevin Coffman <[email protected]>
Thanks. I've combined this with the original patch.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt